Fix JabRef-post-image.wsf to make it agnostic to the location of the … by alexeysemenyukoracle · Pull Request #13033 · JabRef/jabref

alexeysemenyukoracle · 2025-04-29T16:35:21Z

Fix JabRef-post-image.wsf script to make it independent of the project build location.

Build-only change to eliminate dependencies on the context in which the "post-image" jpackage script is called on Windows.

Closes #13034

Important: the baseline for the fix is v6.0-alpha2 tag. There is no JabRef-post-image.wsf in the main branch after #12990, so this PR can not be integrated as-is.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
[/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
[/] Manually tested changed features in running JabRef (always required)
[/] Screenshots added in PR description (if change is visible to the user)
[/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
[/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…project build directory

Siedlerchr · 2025-04-29T17:27:01Z

Thanks for the contribution! Looks good from my side. Would you please resolce the conflicts then we can merge it!

Siedlerchr · 2025-04-29T17:41:25Z

Due to the modularization which we merged after the alpha, the jpackage resources are now under jabgui/buildres/windows and in the corresponding build gradle file.

alexeysemenyukoracle · 2025-04-29T17:50:00Z

Right, but there is no JabRef-post-image.wsf script in these resources anymore. Instead, there is "main.wxs". If this is a permanent fix and not a temporary workaround for jpackage's bug in JDK24, then this pull request can be discarded. Otherwise, I can merge and integrate it later.

Siedlerchr · 2025-04-29T18:18:30Z

I totally overlooked that it was integrated into the main.wxs now. I think it was originally meant to be a workaround by @koppor but could be a permanent solution now as well if it works as intended.

koppor · 2025-04-30T04:52:44Z

I think, we should get this in. The idea of the script was IMHO: Take the JDK generated main.w... file as "leading X and add necessary things afterwards.

I will try to take care later.

(And @alexeysemenyukoracle thank you so much for the time invested!)

koppor · 2025-04-30T09:27:58Z

As far as I understood openjdk/jdk#19318 (comment) and https://bugs.openjdk.org/browse/JDK-8355651, we should update to JDK25 to have the script working again? 😅

koppor · 2025-04-30T09:40:03Z

Blocked by:

gradle not supporting JDK EA builds for toolhcain: Support JDK EA versions for toolchain downloads gradle/gradle#14814
gradle not supporting Java 25 at all: Support compiling and testing on Java 25 gradle/gradle#33310

Debugging more:

JDK 25 is available on the DISCO API: https://api.foojay.io/swagger-ui#/default/getDistributionV3
I cannot convince gradle to resolve that: Duplicate configuration for repository 'foojay'. gradle/foojay-toolchains#109
Trying with mise to install JDK-EA: Java release type setting not honored? jdx/mise#2991 (reply in thread)

Wishes:

Add support for mise locations. gradle/foojay-toolchains#110 be implemented
Auto-detection of installed toolchains by mise gradle/gradle#29355 be implemented

koppor · 2025-04-30T12:40:52Z

Windows:

> Could not copy file 'D:\a\jabref\jabref\jabgui\buildres\windows\JabRef-post-image.wsf' to 'D:\a\jabref\jabref\jabgui\build\jpackage-resource-dir\JabRef-post-image.wsf'.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
   > Error - Invalid filter specification for org.apache.tools.ant.filters.ReplaceTokens

The ChatGPT-solution (dc293db) seems to be wired... Needs more investigation.

alexeysemenyukoracle · 2025-04-30T14:52:36Z

I'd stick to the current workaround with "main.wxs" and revisit this PR later when you decide to migrate to a newer JDK version.

…mage # Conflicts: # jabgui/build.gradle.kts

koppor · 2025-06-07T21:54:21Z

I merged upstream/main (and resolved conflicts). CI shows

 > Could not copy file 'D:\a\jabref\jabref\jabgui\buildres\windows\JabRef-post-image.wsf' to 'D:\a\jabref\jabref\jabgui\build\jpackage-resource-dir\JabRef-post-image.wsf'.

   > Error - Invalid filter specification for org.apache.tools.ant.filters.ReplaceTokens
[Incubating] Problems report is available at: file:///D:/a/jabref/jabref/build/reports/problems/problems-report.html

Too late here for a proper-follow-up now. 😅

trag-bot · 2025-06-17T00:43:41Z

@trag-bot didn't find any issues in the code! ✅✨

* upstream/just-jdk25: Use LTWA file from mirror (JabRef#14892) Re-enable JavaDoc formatting (JabRef#14860)

Siedlerchr · 2026-01-22T19:49:46Z

+        wxsFile.Close();
+
+        // Add registry values for JabRef Browser Extension
+        contents = contents.replace("</Product>", "<DirectoryRef Id=\"TARGETDIR\"><Component Id=\"RegistryJabRefBrowserEntries\" Guid=\"b6bc55ad-905c-4258-89b1-8b37abbe559c\" Win64=\"yes\"><RegistryKey Root=\"HKMU\" Key=\"SOFTWARE\\Mozilla\\NativeMessagingHosts\\org.jabref.jabref\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Value=\"[INSTALLDIR]jabref-firefox.json\"/></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Google\\Chrome\\NativeMessagingHosts\\org.jabref.jabref\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Value=\"[INSTALLDIR]jabref-chrome.json\"/></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Microsoft\\Edge\\NativeMessagingHosts\\org.jabref.jabref\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Value=\"[INSTALLDIR]jabref-chrome.json\"/></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Google\\Chrome\\Extensions\\bifehkofibaamoeaopjglfkddgkijdlh\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Name=\"update_url\" Value=\"https://clients2.google.com/service/update2/crx\" /></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Wow6432Node\\Google\\Chrome\\Extensions\\bifehkofibaamoeaopjglfkddgkijdlh\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Name=\"update_url\" Value=\"https://clients2.google.com/service/update2/crx\" /></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Microsoft\\Edge\\Extensions\\pgkajmkfgbehiomipedjhoddkejohfna\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Name=\"update_url\" Value=\"https://edge.microsoft.com/extensionwebstorebase/v1/crx\" /></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Wow6432Node\\Microsoft\\Edge\\Extensions\\pgkajmkfgbehiomipedjhoddkejohfna\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Name=\"update_url\" Value=\"https://edge.microsoft.com/extensionwebstorebase/v1/crx\" /></RegistryKey></Component></DirectoryRef><Feature Id=\"BrowserExtension\" Level=\"1\"><ComponentRef Id=\"RegistryJabRefBrowserEntries\" /></Feature></Product>");


See PR #14884 we need to adapt this

koppor · 2026-01-22T20:28:33Z

Blocked by gradle/gradle#20930 (comment)

- Task `:jabgui:genPostImageWsf` of type `Build_gradle$WriteTinyFile`: cannot serialize Gradle script object references as these are not supported with the configuration cache.

github-actions · 2026-03-17T03:54:05Z

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

Fix JabRef-post-image.wsf to make it agnostic to the location of the …

28be33f

…project build directory

alexeysemenyukoracle marked this pull request as ready for review April 29, 2025 16:49

alexeysemenyukoracle mentioned this pull request Apr 29, 2025

8319457: Update jpackage to support WiX v4 and v5 on Windows openjdk/jdk#19318

Closed

3 tasks

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 29, 2025

move to jabgui

407af96

fix errors and convert to build dir from layout

65eb404

JabRef deleted a comment from jabref-machine Apr 29, 2025

koppor mentioned this pull request Apr 30, 2025

Support compiling and testing on Java 25 gradle/gradle#33310

Closed

8 tasks

koppor added status: depends-on-external A bug or issue that depends on an update of an external library and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Apr 30, 2025

koppor mentioned this pull request Apr 30, 2025

Enable JDK-EA builds again #13036

Closed

1 task

Delete jabgui/buildres/windows/main.wxs

2effd78

Merge remote-tracking branch 'upstream/main' into fix-jpackage-post-i…

c275455

…mage # Conflicts: # jabgui/build.gradle.kts

koppor added the dev: no-bot-comments If set, there should be no comments from our bots label Jun 17, 2025

Merge branch 'main' into fix-jpackage-post-image

4ee3c05

koppor added 4 commits September 29, 2025 20:09

Update to JDK25

c8ab7ce

No more icon

9afbfe1

Merge remote-tracking branch 'origin/main' into jdk25

e6ec58d

Try other icon file names

eeb401d

koppor and others added 21 commits January 17, 2026 01:02

Streamline number of files required to update

367dd04

Fix some grammar mistakes

70d8150

Merge remote-tracking branch 'origin/main' into just-jdk25

c7fad24

Merge branch 'main' into just-jdk25

0f16d0a

readd mac os resources

f981cf7

update javafx to25.02 and see if they have it for arm

2a2d5a3

Merge remote-tracking branch 'origin/main' into just-jdk25

7cc83c2

Merge branch 'main' into just-jdk25

3447480

remove plist lite

e0c42bd

Merge remote-tracking branch 'upstream/just-jdk25' into just-jdk25

7864c86

* upstream/just-jdk25: Use LTWA file from mirror (JabRef#14892) Re-enable JavaDoc formatting (JabRef#14860)

Fix JavaDoc task

28447f7

Merge branch 'main' into just-jdk25

0db2693

Merge branch 'main' into just-jdk25

c0cf299

Refine check

2504759

Fix directory name

9a9d4c5

Try other command

78e76ad

Trigger build

b27a3d0

Change icon

a50cea8

More output

0aa4207

Magic merge commit for PR JabRef#14057

36dab08

Merge into fix-jpackage-post-image

8ef1dde

Siedlerchr reviewed Jan 22, 2026

View reviewed changes

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Jan 22, 2026

koppor added this to the 6.0-alpha.6 milestone Jan 23, 2026

koppor mentioned this pull request Feb 1, 2026

Windows installer doesn't show JabRef icon #14965

Closed

Siedlerchr modified the milestones: 6.0-alpha.6, 6.0-beta Mar 16, 2026

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Mar 17, 2026

Uh oh!

Conversation

alexeysemenyukoracle commented Apr 29, 2025 • edited by koppor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

Siedlerchr commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Apr 29, 2025

Uh oh!

alexeysemenyukoracle commented Apr 29, 2025

Uh oh!

Siedlerchr commented Apr 29, 2025

Uh oh!

koppor commented Apr 30, 2025

Uh oh!

koppor commented Apr 30, 2025

Uh oh!

koppor commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koppor commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeysemenyukoracle commented Apr 30, 2025

Uh oh!

koppor commented Jun 7, 2025

Uh oh!

trag-bot Bot commented Jun 17, 2025

Uh oh!

Siedlerchr Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

koppor commented Jan 22, 2026

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexeysemenyukoracle commented Apr 29, 2025 •

edited by koppor

Loading

Siedlerchr commented Apr 29, 2025 •

edited

Loading

koppor commented Apr 30, 2025 •

edited

Loading

koppor commented Apr 30, 2025 •

edited

Loading