Conversation
This was referenced Apr 27, 2025
calixtus
previously approved these changes
Apr 27, 2025
calixtus
approved these changes
Apr 27, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
2 tasks
This was referenced Apr 27, 2025
Merged
7 tasks
1 task
1 task
1 task
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces gradle multi project build.
TODO
java.lang.module.FindException: Module mysql.connector.j not found, required by org.newsclub.net.mysqlError: This JDK does not contain packaged modules and cannot be used to create another image with the jdk.jlink modulejava.base module not found in /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/24.0.1-9/x64/jmods--> partially fixed by downgrade to JDK23WARNING: Use --enable-native-access=com.sun.jna to avoid a warning for callers in this module
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/867
Done:
Removed:
Direct follow-up
Future work
(Moved to internal issue tracker https://github.com/JabRef/jabref-issue-melting-pot/issues/879)
@DisabledOnCiandTreeNodeTestDataCreateProcess error=206, The filename or extension is too long- refine Add usage of java Command-Line Argument File on Windows java9-modularity/gradle-modules-plugin#282 with test modules.gitignorecontainsIcon, because of macOS GitHub global GitIgnore file.On Windows,
iconis equal toIconand therefore folders withiconis ignored.Diagram for deciding on a JDK: https://stackoverflow.com/a/61337953/873282
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)