Conversation
Member
|
Related (because language dependent): #13901 |
|
@trag-bot didn't find any issues in the code! ✅✨ |
# Conflicts: # jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java # jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
Member
|
Prototype for workspace preferences - needs to be continued for the other preferences. We prepared the UI under the assumption that the adaption will be done soon. |
Member
|
Strange that following string still apperas: - "You must restart JabRef for this to come into effect." |
Member
Author
Fixed. Was about a duplicated property in WorkspacePreferences that was removed. |
koppor
approved these changes
Nov 20, 2025
2 tasks
Member
|
No CHANGELOG.md yet, because issue #12655 not fixed. The behavior of removing the warning message is too little. |
Member
Author
calixtus
commented
Nov 20, 2025
| return workspacePreferences; | ||
| } | ||
|
|
||
| private WorkspacePreferences getWorkspacePreferencesFromLowLevelApi(WorkspacePreferences defaults) { |
Member
Author
There was a problem hiding this comment.
Should be renamed in followup to "getWorkspacePreferencesFromBackingStore"
This was referenced Nov 23, 2025
Merged
2 tasks
manojalluri
added a commit
to manojalluri/jabref
that referenced
this pull request
Nov 27, 2025
…rom PR JabRef#13894 (WorkspacePreferences) Closes JabRef#14413
3 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Refs #12655 (Importing into a present, observable and mutable preferences object)
Refs #10177 (Cleaning up dependencies to prefs)
Refs #12990 (Cleaning up JabRefGuiPreferences / JabRefCliPreferences
Follow up to #10002
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)