Refactor SpecialFieldsPreferences to support reset/reload (#14409)#14508
Merged
calixtus merged 1 commit intoJabRef:mainfrom Dec 3, 2025
Merged
Refactor SpecialFieldsPreferences to support reset/reload (#14409)#14508calixtus merged 1 commit intoJabRef:mainfrom
calixtus merged 1 commit intoJabRef:mainfrom
Conversation
koppor
requested changes
Dec 3, 2025
Member
koppor
left a comment
There was a problem hiding this comment.
Seems to be good. Requesting a second review.
koppor
approved these changes
Dec 3, 2025
calixtus
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14409
Refactored
SpecialFieldsPreferencesto follow the same pattern asWorkspacePreferences(PR #13894), enabling proper reset and reload functionality. Added a private default constructor,getDefault()static method, andsetAll()method toSpecialFieldsPreferences. UpdatedJabRefGuiPreferencesto use the newgetSpecialFieldsPreferencesFromBackingStore()method and integrated reset/reload support inclear()andimportPreferences()methods.Steps to test
Test preference reset:
Test preference import:
specialFieldsEnabledvalueVerify normal operation:
Mandatory checks
I own the copyright of the code submitted and I license it under the MIT license
[/] I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
[/] I added screenshots in the PR description (if change is visible to the user)
[/] I described the change in
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)[/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.