Fix copy to#13741
Merged
Siedlerchr merged 7 commits intomainfrom Aug 25, 2025
Merged
Conversation
subhramit
previously approved these changes
Aug 23, 2025
Member
subhramit
left a comment
There was a problem hiding this comment.
Code comments were very useful
Siedlerchr
reviewed
Aug 23, 2025
| ImportHandler importHandler) { | ||
| Menu copyToMenu = factory.createMenu(StandardActions.COPY_TO); | ||
| copyToMenu.disableProperty().bind( | ||
| Bindings.size(stateManager.getOpenDatabases()).lessThan(2) |
Member
There was a problem hiding this comment.
Use Action Helper needs multiple datahases
jabref/jabgui/src/main/java/org/jabref/gui/actions/ActionHelper.java
Lines 41 to 43 in dd823a4
Siedlerchr
reviewed
Aug 23, 2025
| }; | ||
|
|
||
| // EasyBind.subscribe() is not available for lists, therefore "manually" triggering rebuild and subscribing | ||
| rebuildMenu.run(); |
Member
There was a problem hiding this comment.
You can directly call subscribe on lists:
stateManager.getOpenDatabases().subscribe( Runnable )
Siedlerchr
reviewed
Aug 23, 2025
Co-authored-by: Christoph <siedlerkiller@gmail.com>
| ); | ||
|
|
||
| ObservableList<BibDatabaseContext> openDatabases = stateManager.getOpenDatabases(); | ||
| // Menu is created on each right-click, thus we can always assume that the list of open databases is up-to-date |
There was a problem hiding this comment.
Comment restates what is obvious from the code context and doesn't provide additional value or reasoning. Comments should add new information not derivable from code.
subhramit
approved these changes
Aug 24, 2025
Siedlerchr
approved these changes
Aug 25, 2025
Siedlerchr
added a commit
that referenced
this pull request
Sep 8, 2025
* upstream/main: (32 commits) Fix path (#13769) Mode aware consistency check (#13584) Refine JBang check (#13765) Add Language Server to the UI and add the integrity/consistency check (#13697) Fix/remove comment code (#13763) New Crowdin updates (#13760) Bump org.openrewrite.rewrite from 7.14.0 to 7.14.1 (#13757) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13756) Bump dev.langchain4j:langchain4j-bom from 1.2.0 to 1.3.0 in /versions (#13755) Bump jablib/src/main/resources/csl-locales from `fa56de1` to `e29c453` (#13754) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13753) Bump org.mockito:mockito-core from 5.18.0 to 5.19.0 in /versions (#13752) Bump actions/upload-pages-artifact from 3 to 4 (#13751) Migrate fetchers to Search.g4 ANTLR parser. (#13691) [Junie]: fix: resolve IllegalArgumentException for non-absolute URIs (#13669) Add auto-renaming of linked files on entry data change (#13295) Walkthrough additions (#13745) Switch from zulu to corretto (#13749) New Crowdin updates (#13747) Fix copy to (#13741) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #12374 had several issues
This PR fixes it.
Steps to test
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)