Conversation
koppor
added
the
automerge
|
Update |
This reverts commit c8939b4.
|
w/ Corretto one really needs major versions only - otherwise |
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
we only needed that for setting up jpackage |
| with: | ||
| java-version: 24.0.1 | ||
| distribution: 'zulu' | ||
| java-version: 24 |
There was a problem hiding this comment.
I don't like the version downgrade here!
There was a problem hiding this comment.
And #13749 (comment)
Corretto does not work with 24.0.2.
There was a problem hiding this comment.
I trust setup-java to fetch the latest version (as promised in their README.md).
Eventually (in the English sense), we need to work on switching back to Temurin! https://github.com/JabRef/jabref-issue-melting-pot/issues/1041
There was a problem hiding this comment.
Ah thanks, was not aware of this. Seems to work Downloading Java 24.0.2+12.1 (Corretto) from https://corretto.aws/downloads/resources/24.0.2.12.1/amazon-corretto-24.0.2.12.1-macosx-x64.tar.gz ...
* upstream/main: (32 commits) Fix path (#13769) Mode aware consistency check (#13584) Refine JBang check (#13765) Add Language Server to the UI and add the integrity/consistency check (#13697) Fix/remove comment code (#13763) New Crowdin updates (#13760) Bump org.openrewrite.rewrite from 7.14.0 to 7.14.1 (#13757) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13756) Bump dev.langchain4j:langchain4j-bom from 1.2.0 to 1.3.0 in /versions (#13755) Bump jablib/src/main/resources/csl-locales from `fa56de1` to `e29c453` (#13754) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13753) Bump org.mockito:mockito-core from 5.18.0 to 5.19.0 in /versions (#13752) Bump actions/upload-pages-artifact from 3 to 4 (#13751) Migrate fetchers to Search.g4 ANTLR parser. (#13691) [Junie]: fix: resolve IllegalArgumentException for non-absolute URIs (#13669) Add auto-renaming of linked files on entry data change (#13295) Walkthrough additions (#13745) Switch from zulu to corretto (#13749) New Crowdin updates (#13747) Fix copy to (#13741) ...
3 participants
Risen by #13584 (comment)
While we experimented with different VMs (refs adoptium/adoptium-support#1271 (comment)), we switched to zulu - and then to correto.
This PR sould make it consistent.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)