Conversation
Member
|
Requires gradle 9.1 |
Member
Author
Then: Runners to 24; 25 is installed via toolchain 😅 Or wait until we updated our Gradle fork |
Member
Author
|
With #13719, we use the most recent gradle development version |
Member
Author
Member
Author
|
seems to be fine for macOS: |
Member
Author
Member
Author
|
Seems to be the right commit - 0ae6281 |
Member
Author
|
macOS does not run with Amazon: |
Member
Author
|
|
Member
|
Member
Author
Member
Author
Member
Author
|
Notarization works, too - https://github.com/JabRef/jabref/actions/runs/21310215959
|
Member
Author
|
Tested in this branch, will merge to be sure that it works :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






User description
JDK 26 and JavaFX can be build using workflow dispatch -- regular builds still use release versions.
Major effort because of https://bugs.openjdk.org/browse/JDK-8342623
Tests - macOS EA build
.bibfiles right - if not, we need to create a secondjabref-bibtex.icnsfile with a different name than the application icon and relink inbibtexAssociations.properties.This PR builds on #14057.
This PR tries to enable EA builds - to be able to report back to be able to report earlier to https://wiki.openjdk.org/display/quality/Quality+Outreach.
Eclipse Temurin's binaries should soon be available:
WIP, because Temurin is not yet available. AKA blocked by adoptium/temurin#96.
Hopefully, we can go back to Temurin (refs adoptium/adoptium-support#1271 (comment) and #13749
Uses "latest" for the dev container to reduce the places where we need to adapt version numbers.
Refs #13933
Maybe related issues
Steps to test
Run JabRef 😅
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)PR Type
Enhancement
Description
Enable Early-Access JDK builds via workflow dispatch inputs
Add configurable JDK version, branch, and JavaFX version parameters
Reorganize build job steps for better artifact upload management
Remove JabSrv-CLI and JabLS-CLI from main build, keep as smoke tests
Fix JavaFX module configuration for EA JDK compatibility
Diagram Walkthrough
File Walkthrough
binaries.yml
Add EA JDK build support and reorganize build steps.github/workflows/binaries.yml
useEaJdk,jdkVersion,jdkVersionBranch, andjavafxVersionenabled
versions
consolidate upload steps
smoke tests
comment-on-issue-and-pr job
directory
org.jabref.gradle.base.dependency-rules.gradle.kts
Fix JavaFX module naming for EA JDK compatibilitybuild-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts
javafx-baseinstead of
base)jdk-jsobjectto the module list for proper dependency resolutionjdk-jsobjectas it's now handledin the main list
build.gradle.kts
Add jdk-jsobject dependency and fix Linux packagingjabgui/build.gradle.kts
org.openjfx:jdk-jsobjectwith reference toJDK-8342623 bug
--linux-rpm-license-typeoption as Ubuntu uses debpackages, not rpm
Chocolate.jmp
Add Chocolate.jmp mind map resource filejablib/src/main/resources/Chocolate.jmp
build.gradle.kts
Update JavaFX version documentation and formattingversions/build.gradle.kts
binaries.yml