Skip to content

fix: Improper icon sizing with respect to font size#13841

Merged
Siedlerchr merged 1 commit intoJabRef:mainfrom
Yubo-Cao:main
Sep 9, 2025
Merged

fix: Improper icon sizing with respect to font size#13841
Siedlerchr merged 1 commit intoJabRef:mainfrom
Yubo-Cao:main

Conversation

@Yubo-Cao
Copy link
Copy Markdown
Collaborator

@Yubo-Cao Yubo-Cao commented Sep 9, 2025

Closes N/A

Steps to test

Open JabRef and tweak font size. Now the icon in toolbar works properly under all sort of font size.

default:
image
13pt:
image
10pt:
image

Would greatly appreciate testing from other platforms. The screenshot above is obtained from a Windows 25H2 machine.

Mandatory checks

@jabref-machine
Copy link
Copy Markdown
Collaborator

You committed your code on the main brach of your fork. This is a bad practice. The right way is to branch out from main, work on your patch/feature in that new branch, and then get that branch merged via the pull request (see GitHub flow).

For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details.

.mainToolbar .glyph-icon,
.mainToolbar .ikonli-font-icon {
-fx-font-size: 1.7em;
/* `!important` is override library's default font size */
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a grammatical error. It should be 'to override' instead of 'is override'. Comments should be properly formatted and grammatically correct.

@Siedlerchr
Copy link
Copy Markdown
Member

Thanks for the quick action. Will test it later today

Copy link
Copy Markdown
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks greaT!
grafik

@Siedlerchr
Copy link
Copy Markdown
Member

Siedlerchr commented Sep 9, 2025

Just one thing left I think : Filter groups search bar field has a different size maybe like the half of the other
grafik

@Siedlerchr
Copy link
Copy Markdown
Member

merging for now

@Siedlerchr Siedlerchr merged commit 9b13538 into JabRef:main Sep 9, 2025
36 checks passed
Siedlerchr added a commit that referenced this pull request Sep 9, 2025
* upstream/main:
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
Siedlerchr added a commit that referenced this pull request Sep 11, 2025
* upstream/main:
  Fix NoSuchElementException in ThreeWayMerge dialog (#13838)
  Keep global search bar open when  keep on top pin is selected (#13846)
  Spell "BibDesk" with capital "D" (#13847)
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants