fix: Improper icon sizing with respect to font size#13841
Merged
Siedlerchr merged 1 commit intoJabRef:mainfrom Sep 9, 2025
Merged
fix: Improper icon sizing with respect to font size#13841Siedlerchr merged 1 commit intoJabRef:mainfrom
Siedlerchr merged 1 commit intoJabRef:mainfrom
Conversation
Collaborator
|
You committed your code on the For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details. |
| .mainToolbar .glyph-icon, | ||
| .mainToolbar .ikonli-font-icon { | ||
| -fx-font-size: 1.7em; | ||
| /* `!important` is override library's default font size */ |
There was a problem hiding this comment.
The comment contains a grammatical error. It should be 'to override' instead of 'is override'. Comments should be properly formatted and grammatically correct.
Member
|
Thanks for the quick action. Will test it later today |
Member
Member
|
merging for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes N/A
Steps to test
Open JabRef and tweak font size. Now the icon in toolbar works properly under all sort of font size.
default:



13pt:
10pt:
Would greatly appreciate testing from other platforms. The screenshot above is obtained from a Windows 25H2 machine.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)