Skip to content

Keep global search bar open when keep on top pin is selected#13846

Merged
koppor merged 2 commits intomainfrom
globalSearchBar
Sep 10, 2025
Merged

Keep global search bar open when keep on top pin is selected#13846
koppor merged 2 commits intomainfrom
globalSearchBar

Conversation

@Siedlerchr
Copy link
Copy Markdown
Member

@Siedlerchr Siedlerchr commented Sep 9, 2025

Closes #13840

I could not get the "Just move the window to the back" thing working. Either the whole application was moved to background or nothing happened. Tried various things

Steps to test

Have library with entries
Open global search dialog
click on pin to keep on top
double click on entry
=> window stays open

Mandatory checks

@Siedlerchr Siedlerchr requested a review from koppor September 9, 2025 19:08
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 9, 2025
Copy link
Copy Markdown
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out works.

The second TODO is not working: "Pin on top off: window should behave "normal" w.r.t. JabRef main window (meaning going to the background if main window is activated)"

Comment thread jabgui/src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java Outdated
@Siedlerchr
Copy link
Copy Markdown
Member Author

The second TODO is not working: "Pin on top off: window should behave "normal" w.r.t. JabRef main window (meaning going to the background if main window is activated)"

This is what I just wrote in the description of the PR..

@trag-bot
Copy link
Copy Markdown

trag-bot Bot commented Sep 9, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit 015370b Sep 10, 2025
39 checks passed
@koppor koppor deleted the globalSearchBar branch September 10, 2025 09:20
Siedlerchr added a commit that referenced this pull request Sep 11, 2025
* upstream/main:
  Fix NoSuchElementException in ThreeWayMerge dialog (#13838)
  Keep global search bar open when  keep on top pin is selected (#13846)
  Spell "BibDesk" with capital "D" (#13847)
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global Search: Change of Pin behavior

2 participants