Keep global search bar open when keep on top pin is selected#13846
Merged
Keep global search bar open when keep on top pin is selected#13846
Conversation
e6bf282 to
68b348a
Compare
koppor
reviewed
Sep 9, 2025
Member
koppor
left a comment
There was a problem hiding this comment.
Tried out works.
The second TODO is not working: "Pin on top off: window should behave "normal" w.r.t. JabRef main window (meaning going to the background if main window is activated)"
Member
Author
This is what I just wrote in the description of the PR.. |
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Sep 10, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13840
I could not get the "Just move the window to the back" thing working. Either the whole application was moved to background or nothing happened. Tried various things
Steps to test
Have library with entries
Open global search dialog
click on pin to keep on top
double click on entry
=> window stays open
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)