Skip to content

Fixed #284. Added support for direction control.#1232

Closed
Kingwl wants to merge 2 commits intoJedWatson:masterfrom
Kingwl:master
Closed

Fixed #284. Added support for direction control.#1232
Kingwl wants to merge 2 commits intoJedWatson:masterfrom
Kingwl:master

Conversation

@Kingwl
Copy link

@Kingwl Kingwl commented Sep 20, 2016

Fixes #284 . This adds support for select direction of menu

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.014% when pulling 091e4dd on Kingwl:master into 2b14448 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.014% when pulling 336df18 on Kingwl:master into 2b14448 on JedWatson:master.

@rvignacio
Copy link

Any chance we get this merged?

@JedWatson
Copy link
Owner

Thanks for the PR @Kingwl and sorry it's taken so long to review.

Makes sense as a prop, but I'm wondering if/how this should interact with auto-detecting space around the control instead if we were to implement that?

What are your thoughts?

@AndersDJohnson
Copy link

@JedWatson It'd be great if this feature made it into a release soon.

@burtyish
Copy link
Contributor

Makes sense as a prop, but I'm wondering if/how this should interact with auto-detecting space around the control instead if we were to implement that?

@JedWatson FYI, #810 mentions a solution which provides automatically determining the direction based on available space via usage of tether.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants