Fixed #284. Added support for direction control.#1232
Closed
Kingwl wants to merge 2 commits intoJedWatson:masterfrom
Closed
Fixed #284. Added support for direction control.#1232Kingwl wants to merge 2 commits intoJedWatson:masterfrom
Kingwl wants to merge 2 commits intoJedWatson:masterfrom
Conversation
|
Any chance we get this merged? |
Owner
|
Thanks for the PR @Kingwl and sorry it's taken so long to review. Makes sense as a prop, but I'm wondering if/how this should interact with auto-detecting space around the control instead if we were to implement that? What are your thoughts? |
|
@JedWatson It'd be great if this feature made it into a release soon. |
Contributor
@JedWatson FYI, #810 mentions a solution which provides automatically determining the direction based on available space via usage of |
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284 . This adds support for select direction of menu