removeSelected prop (round 2), for optionally keeping selected values in dropdown#1891
removeSelected prop (round 2), for optionally keeping selected values in dropdown#1891JedWatson merged 17 commits intoJedWatson:masterfrom banderson:remove-selected
Conversation
… the same structure/order as 'options'
|
Hi @banderson thank you for this. Since this adds a new prop this will need unit tests and documentation. Can you add these? |
|
@agirton I just updated this to include:
The original author (@dherran) already added docs to the example site. I tried to follow the testing style that was there, let me know if there's anything else I can do to help get this in! /cc @TrevorBurnham |
README.md
Outdated
| You can enable multi-value selection by setting `multi={true}`. In this mode: | ||
|
|
||
| * Selected options will be removed from the dropdown menu | ||
| * Selected options will be removed from the dropdown menu by default. If you want them to remain in the list, set `removeSelected={true}` |
There was a problem hiding this comment.
@banderson just a minor nit: should this be "If you want them to remain in the list, set removeSelected={false}"?
|
Is there anything currently blocking this (besides the true -> false change in the docs)? We could really need this aswell and I'd be happy to help with any remaining steps so this PR can be merged :) |
|
Two test cases were broken btw, fixed them here: |
gwyneplaine
left a comment
gwyneplaine
left a comment
There was a problem hiding this comment.
good to go @JedWatson
|
Thanks everyone! This is good to land 👍 |
7 participants
I forked what @dherran did with #882 to resolve conflicts with master and to implement PR feedback from @agirton, so defer to #882 and the original issue for more details: #803
This is in a holding state until we decide what to do here. But this should work as expected, and all tests are passing.