Skip to content

removeSelected: bool#2024

Closed
firedev wants to merge 1 commit intoJedWatson:masterfrom
firedev:removeSelected
Closed

removeSelected: bool#2024
firedev wants to merge 1 commit intoJedWatson:masterfrom
firedev:removeSelected

Conversation

@firedev
Copy link

@firedev firedev commented Sep 27, 2017

When removeSelected is set to false you can add same item multiple
times

Changed removal logic to remove values based on position

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 0ad0471 on firedev:removeSelected into 7523c20 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 0ad0471 on firedev:removeSelected into 7523c20 on JedWatson:master.

When `removeSelected` is set to `false` you can add same item multiple
times

Changed removal logic to remove values based on position
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 430bf2c on firedev:removeSelected into 7523c20 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 430bf2c on firedev:removeSelected into 7523c20 on JedWatson:master.

@gwyneplaine
Copy link
Collaborator

Thanks for this @firedev, we've opted with a removeSelected PR that's more generic. Please see the following PR. #1891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants