Centralize babelrc config & use loose mode#2843
Closed
Andarist wants to merge 1 commit intoJedWatson:masterfrom
Closed
Centralize babelrc config & use loose mode#2843Andarist wants to merge 1 commit intoJedWatson:masterfrom
Andarist wants to merge 1 commit intoJedWatson:masterfrom
Conversation
Collaborator
|
Thanks for this!! As mentioned in the other PR, react-select switched to preconstruct a while ago so this mostly isn't relevant anymore. I just opened a new PR, #3797, to enable loose mode because the Babel config has moved to babel.config.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not duplicate babel config in rollup.config.js, should be easier to keep this in sync now
loose mode - mainly bundle size optiomation. Measuring with
npx terser -cm --toplevel dist/react-select.esm.js | gzip -c | wc -cfrom 19047 bytes to 18545 bytes. Should u chose loose mode? Thread - https://twitter.com/brian_d_vaughn/status/1021183132135931905