Skip to content

update npm deps: babel@7 rollup@1#3366

Merged
gwyneplaine merged 8 commits intoJedWatson:masterfrom
DragorWW:build-tools-upgrade
Jan 25, 2019
Merged

update npm deps: babel@7 rollup@1#3366
gwyneplaine merged 8 commits intoJedWatson:masterfrom
DragorWW:build-tools-upgrade

Conversation

@DragorWW
Copy link
Contributor

I selected dependent modules from PR update flow

update:

  • babel@6 to babel@7
  • rollup@0 to rollup@1
  • extract-react-types-loader
  • pretty-proptypes

- babel@6 to babel@7
- rolup@0 to rollup@1
- extract-react-types-loader
- pretty-proptypes
@gwyneplaine
Copy link
Collaborator

@DragorWW thanks for this PR, added questions / actions where relevant.

@gwyneplaine
Copy link
Collaborator

thanks for resolving those comments @DragorWW, once @TrySound's feedback has been addressed I'll merge this in 👍

@DragorWW
Copy link
Contributor Author

DragorWW commented Jan 23, 2019

@gwyneplaine @TrySound All is well? Are there any reasons not to merge? If you need to fix something else, write 👍

And babel config optimization can be done in PR #2843

@gwyneplaine
Copy link
Collaborator

@DragorWW did another smoke test of this work, our PropType documentation is now no longer working. Having a look at this now, if you want to dig into it as well that would be helpful, once that's resolved we can merge.

@DragorWW
Copy link
Contributor Author

DragorWW commented Jan 24, 2019

@gwyneplaine I forgot about in new version extract-react-types-loader this display of PropTypes only work there are environment variables WEBSITE_ENV == 'staging' | 'production' or FORCE_EXTRACT_REACT_TYPES

I think the variable FORCE_EXTRACT_REACT_TYPES will be a more explicit choice.

in deploy/netlify, I’m calling nps build.docs directly. I added to it env.

11:12:40 PM: Executing user command: nps build.docs
11:12:41 PM: nps is executing `build.docs` : node node_modules/rimraf/bin.js docs/dist && webpack --progress -p
11:12:41 PM:   0% compiling
11:12:41 PM:  10% building modules 0/1 modules 1 active ...ndex.js!/opt/build/repo/docs/index.js

@DragorWW
Copy link
Contributor Author

@DragorWW did another smoke test of this work, our PropType documentation is now no longer working. Having a look at this now, if you want to dig into it as well that would be helpful, once that's resolved we can merge.

fix it

@gwyneplaine
Copy link
Collaborator

Merged, thanks @DragorWW

@gwyneplaine gwyneplaine reopened this Jan 25, 2019
@gwyneplaine gwyneplaine merged commit f1aaef4 into JedWatson:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants