Updates, fixes, optimization#3249
Updates, fixes, optimization#3249vadimka123 wants to merge 20 commits intoJedWatson:masterfrom vadimka123:master
Conversation
|
Was coming here regarding a similar performance issue where react-select isn't being interacted with yet but is still hogging up the flame graph. Happy to provide profile if necessary |
|
@kylealwyn, please, provide profile |
|
@gwyneplaine this is very nice, worth taking a look. Looking forward to having it merged |
|
looking forward to this seeing this merged. the |
|
@JedWatson, any progress on review ? |
|
@vadimka123 thanks, I'm using your fork and looking great, it's a salvation for my project! Note to others: It looks like it still requires: @JedWatson please could you review this PR? It's solving critical performance issues, very important. |
|
@vadimka123 great work, but IMHO your PR mix too much different concerns, and your changes will have more chances to be merged if you break it down in several PR. |
|
That perf fix has been merged with #3569 and will be released in a moment |
nullon hitting backspace when backspaceRemovesValue is true and isMulti is falseI'm have page with ~1000 selects with a ~1000 options. When render this page it takes ~ 40-50s and while page either hangs terribly or crashed. After this update page render takes 10s and there are no hangs. It's very need update.
Fixed next issues:
#3128
#3055
#2970
#2711