Fixed isValidNewOption when value is null#3568
Closed
vadimka123 wants to merge 2 commits intoJedWatson:masterfrom
vadimka123:fix-creatable
Closed
Fixed isValidNewOption when value is null#3568vadimka123 wants to merge 2 commits intoJedWatson:masterfrom vadimka123:fix-creatable
vadimka123 wants to merge 2 commits intoJedWatson:masterfrom
vadimka123:fix-creatable
Conversation
Owner
|
Thanks for the PR @vadimka123 I'm not clear on why / when this is a problem. The call to Implementation here (from export const cleanValue = (value: ValueType): OptionsType => {
if (Array.isArray(value)) return value.filter(Boolean);
if (typeof value === 'object' && value !== null) return [value];
return [];
};Is there a logical path I'm missing that allows a falsey value to get through here? What problem is checking for |
Contributor
Author
|
@JedWatson, I have seen this problem for quite some time |
Contributor
Author
|
Yes, it's fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.