Merged
Conversation
Includes tests for setting the placeholder dynamically, and one obscure case where the placeholder is set to the same as the currently selected value's label
Placeholder was compared to state.placeholder, which in the case of a selected value when multi=false, is actually the label of the selected item. This means this comparison was (almost) always returning true, and therefore always recalculating the values. This didn't cause any major issue, just caused extra unnecessary work. (It also meant that the options being set later than the value worked, as the value labels were always recalculated) meant that
Collaborator
Author
|
I've got the rest of the props tested too (see bruderstein/react-select/tree/even-more-tests), but they sadly rely on the small test refactoring that is in this PR. When/if this is merged, I'll rebase and send the rest. |
This was referenced Jul 31, 2015
Merged
Owner
|
Brilliant as usual, @bruderstein 😀 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the placeholder functionality, including the fix in the recent PR (#334)
Also corrects the comparison - this was causing extra unnecessary work by comparing
to state.placeholder instead of props.placeholder