Extract components#352
Merged
JedWatson merged 10 commits intoJedWatson:masterfrom Aug 3, 2015
jniechcial:extract-components
Merged
Extract components#352JedWatson merged 10 commits intoJedWatson:masterfrom jniechcial:extract-components
JedWatson merged 10 commits intoJedWatson:masterfrom
jniechcial:extract-components
Conversation
added 9 commits
August 2, 2015 17:51
This example shows how we can easily integrate other React components thanks to customizable Option/Value component based on React Gravatar component.
Collaborator
|
Cool, I've just rebased this on my even-more-tests branch (this will be sent as a PR if/when PR #348 is merged, as it relies on it), and one test fails. (The tests for valueRenderer are sadly only in this branch) It's a pretty easy fix though, you just need to move the from line 767 to outside the deepest if, otherwise in the case of a single value with a valueRenderer, you pass option={val}, but val isn't defined. After doing that, the test passes, and everything is green. Tests are nice :) |
src/Select.js
Outdated
Collaborator
There was a problem hiding this comment.
Need to move this line up
Author
|
@bruderstein fixed, good to have wide test coverage :) |
Owner
|
#348 is merged :) this looks great @jniechcial, thank you. and thanks to @bruderstein for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR due to rebasing and fixing conflicts, but the discussion available in this PR.