Final batch of tests #356
Merged
Final batch of tests #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createControl and createControlWithWrapper are now used for all tests. This hopefully makes it more obvious how new tests should be written.
Adds tests for removing existing selection from options This will not pass until PR JedWatson#319 is merged
Updated unexpected-dom devDep to 1.2.0
This results in better error messages if something fails e.g. you get expected '<div .....>' to contain no elements matching '.Select-option' instead of expected NodeList[<...>, <....>] to have length 0, but was length 2
This assumes that a disabled option cannot be focused. The tests will need to be changed if this is changed, such that a disabled option can be focused but not selected.
This includes some evil things like all options being disabled and the first option being disabled
This adds an extra line of coverage, but it is important because it's one of the many branches in the focusAdjacentOption function.
bruderstein
force-pushed
the
even-more-tests
branch
from
64adab1 to
4015cd4
Compare
Collaborator
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last batch of tests for the existing functionality. I think that pretty much everything is covered now, although there are obviously many combinations of options that are not covered - we'll add these as bugs are reported, would be my suggestion.
Currently there are 8 failing tests (one for searchable=false and multi=true, and 7 for disabled options).
PR #319 corrects the searchable=false/multi=true test, and PR #346 corrects 4 of the 7 disabled option tests.
I'm sending another PR which fixes the bug causing the last three to fail (but that PR doesn't make sense without #346, hence the separate PR).
I've also got a change for #346, to show the disabled options in a search - I'll send that separately as that's a matter of taste as to whether disabled options should appear after a search. It just "felt" wrong when I tried it in the examples.
I've rebased these PRs and tried out the examples, and all LGTM
Happy to rebase this PR when the fixes are in, if you'd prefer to "stay green" 😄