Allow disabled option #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should I commit the the changes of the dist files? I got more diff than expected. Seems that I'm using some newer version npm packages. |
This was referenced Aug 3, 2015
Merged
Owner
|
Great - thanks @mondaychen. No need to commit the dist files, they're generated when I publish releases. |
bruderstein
added a commit
to bruderstein/react-select
that referenced
this pull request
Aug 6, 2015
Previously (following PR JedWatson#346) a disabled option would show up in the list, until searching, then it would disappear This commit changes that behaviour, so that the option is still shown (when it matches the search), but still cannot be selected. Test added.
bruderstein
added a commit
to bruderstein/react-select
that referenced
this pull request
Aug 8, 2015
Previously (following PR JedWatson#346) a disabled option would show up in the list, until searching, then it would disappear This commit changes that behaviour, so that the option is still shown (when it matches the search), but still cannot be selected. Test added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be useful to allow
{value: "some value", label: "some label", disabled: true}.I noticed that this is already partially implemented. A disabled option gets a classname
is-disabled(with proper css style). And you can no longer select it by mouse click. However you can still select it using keyboard. This PR will fix it. (as described in #274)