Disabled options appear in the search results #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously (following PR JedWatson#346) a disabled option would show up in the list, until searching, then it would disappear This commit changes that behaviour, so that the option is still shown (when it matches the search), but still cannot be selected. Test added.
bruderstein
force-pushed
the
show-disabled-options-in-search
branch
from
534dcc3 to
818f8a5
Compare
Owner
|
I'm inclined to agree with you, @bruderstein. I think that if the option shouldn't be visible, don't include it. If it's included but disabled there must be some information that is intended to convey, so it should remain during search. To do otherwise is confusing. I'm happy to merge this. If there's a compelling reason to support removing disabled options during searches we could always introduce a prop to control this behaviour (not necessary though, IMO). |
JedWatson
added a commit
that referenced
this pull request
Aug 8, 2015
Disabled options appear in the search results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (following PR #346) a disabled option would show up in the list, until searching, then it would disappear.
This commit changes that behaviour, so that the option is still shown (when it matches the search), but still cannot be selected.
Test added.
This is a very subjective PR, so it'd be good to get a few opinions on this - I find it feels weird when you click the arrow to show the states, type 'a', and 'Alabama' disappears. If the caller didn't want to display the option, they'd have removed it from the options, not set it to disabled, but that's just my opinion.