fix: resolve typecheck/lint failures from feature-services PR

[Josh-wt]

Summary

Three targeted fixes for issues introduced by the prior feature-services commit:

• OrchestrationEngine — add explicit case "thread.branch-from-checkpoint": before default: in commandToAggregateRef. The new command uses newThreadId/sourceThreadId rather than threadId, which caused TS2339 in the default fallthrough.
• WorkflowService — inline deleteTemplate to a direct sql tag + .pipe(Effect.orDie), eliminating the single-return Effect.gen wrapper that triggered the TS5 lint message.
• server.ts — change runServer's error channel from any/unknown to never. The anyUnknownInErrorContext (TS28) rule fires for both any and unknown; never is semantically correct for a fully-launched server layer and eliminates TS28 propagation through cli.ts, bin.ts, and cli.test.ts.

Test plan

• bun typecheck exits 0 (only pre-existing TS32 informational messages remain)
• bun lint — 5 pre-existing warnings, 0 errors
• bun fmt --check — all files correctly formatted

https://claude.ai/code/session_01Nxa3JfS5jZVHsnJmaaHvbW

Summary by CodeRabbit

• Refactor

  • Simplified workflow service deletion logic by streamlining control flow.

• Chores

  • Updated server type annotations for improved type safety.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces three focused improvements across the server infrastructure: adding a new command routing case for thread branching from checkpoints, refining an Effect type annotation for error handling clarity, and simplifying SQL delete operation control flow in the workflow service.

Changes

Cohort / File(s)	Summary
Command Routing & Workflow Operations apps/server/src/orchestration/Layers/OrchestrationEngine.ts, apps/server/src/workflow/Services/WorkflowService.ts	Added new command type "thread.branch-from-checkpoint" routed to "thread" aggregate using newThreadId. Refactored delete method from Effect.gen generator to direct SQL query piped through Effect.orDie, simplifying control flow while preserving behavior.
Type Safety Refinement apps/server/src/server.ts	Tightened exported runServer Effect type annotation from Effect.Effect<never, any, ServerConfig> to Effect.Effect<never, never, ServerConfig> for stricter error type tracking.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰✨ A branch springs forth from checkpoints deep,
Commands route where threads now leap!
Types refined with careful care,
SQL flows simplified and fair—
Small changes, mighty in their grace! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the primary objective: fixing typecheck/lint failures from a prior PR, which is the core purpose of all three changes.
Description check	✅ Passed	The PR description comprehensively explains what changed and why with clear technical details, test validation, and a link to the reasoning context; the 'What Changed' section is effectively provided in the 'Summary' and technical breakdown, meeting the template's core requirements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/understand-codebase-9Fmym

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

apps/server/src/workflow/Services/WorkflowService.ts (1)

305-308: Prefer Effect.gen() here to match server async-operation convention.

This works, but it diverges from the project’s server-side Effect style rule.

♻️ Suggested adjustment

 const deleteTemplate: WorkflowServiceShape["delete"] = (input) =>
-  sql`
-    DELETE FROM workflow_templates
-    WHERE id = ${input.templateId} AND is_built_in = 0
-  `.pipe(Effect.orDie);
+  Effect.gen(function* () {
+    yield* sql`
+      DELETE FROM workflow_templates
+      WHERE id = ${input.templateId} AND is_built_in = 0
+    `;
+  }).pipe(Effect.orDie);

As per coding guidelines "Use Effect's `Layer.effect()` for service composition, `Effect.gen()` for async operations, and `Stream` API for event/data streaming in the server architecture".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/workflow/Services/WorkflowService.ts` around lines 305 - 308,
Replace the direct SQL effect pipeline sql`...`.pipe(Effect.orDie) with an
Effect.gen-based async operation per server conventions: wrap the DELETE sql
template call inside an Effect.gen(() => { ... }) block, yield the sql call
inside that generator and handle/propagate errors via the gen's effect flow
(instead of calling .pipe(Effect.orDie) inline). Target the SQL deletion snippet
(the sql`DELETE FROM workflow_templates WHERE id = ${input.templateId} AND
is_built_in = 0` block) in WorkflowService.ts and ensure the returned value is
the Effect produced by Effect.gen so it conforms to the project's
async-operation style.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/server/src/workflow/Services/WorkflowService.ts`:
- Around line 305-308: Replace the direct SQL effect pipeline
sql`...`.pipe(Effect.orDie) with an Effect.gen-based async operation per server
conventions: wrap the DELETE sql template call inside an Effect.gen(() => { ...
}) block, yield the sql call inside that generator and handle/propagate errors
via the gen's effect flow (instead of calling .pipe(Effect.orDie) inline).
Target the SQL deletion snippet (the sql`DELETE FROM workflow_templates WHERE id
= ${input.templateId} AND is_built_in = 0` block) in WorkflowService.ts and
ensure the returned value is the Effect produced by Effect.gen so it conforms to
the project's async-operation style.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1953e723-664d-47b6-a0a1-e3167f62678d

📥 Commits

Reviewing files that changed from the base of the PR and between 5441092 and d8bd4e8.

📒 Files selected for processing (3)

• apps/server/src/orchestration/Layers/OrchestrationEngine.ts
• apps/server/src/server.ts
• apps/server/src/workflow/Services/WorkflowService.ts

[cubic-dev-ai]

No issues found across 3 files