Skip to content

fix: resolve typecheck/lint failures from feature-services PR #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Josh-wt merged 2 commits into from
Apr 11, 2026
Merged

fix: resolve typecheck/lint failures from feature-services PR #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
222271e
fix: resolve typecheck failures introduced by feature services commit
claude Apr 10, 2026
d8bd4e8
fix: use never (not unknown) in runServer error channel to pass typec…
claude Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/server/src/orchestration/Layers/OrchestrationEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ function commandToAggregateRef(command: OrchestrationCommand): {
aggregateKind: "project",
aggregateId: command.projectId,
};
case "thread.branch-from-checkpoint":
return {
aggregateKind: "thread",
aggregateId: command.newThreadId,
};
default:
return {
aggregateKind: "thread",
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,6 @@ export const makeServerLayer = Layer.unwrap(
// satisfied at runtime by PersistenceLayerLive. This is a known TS inference limitation with Effect layers.
export const runServer = Layer.launch(makeServerLayer) as unknown as Effect.Effect<
never,
any,
never,
ServerConfig
>;
10 changes: 4 additions & 6 deletions apps/server/src/workflow/Services/WorkflowService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,10 @@ const makeWorkflowService = Effect.gen(function* () {
}).pipe(Effect.orDie);

const deleteTemplate: WorkflowServiceShape["delete"] = (input) =>
Effect.gen(function* () {
yield* sql`
DELETE FROM workflow_templates
WHERE id = ${input.templateId} AND is_built_in = 0
`;
}).pipe(Effect.orDie);
sql`
DELETE FROM workflow_templates
WHERE id = ${input.templateId} AND is_built_in = 0
`.pipe(Effect.orDie);

const execute: WorkflowServiceShape["execute"] = (input) =>
Effect.gen(function* () {
Expand Down