Merged
Conversation
…24 yet. Let's just do Java 21 for now.
…gin. In order to get the tests to pass, <requiredProperties> much be defined for each property that is referenced in the integration tests' archetype.properties files.
Resolve #497 by requiring Java 21 or later.
…-plugin-3.3.1 Resolve #491 by upgrading to version 3.3.1 of the maven-archetype-plugin.
… are uploaded to Maven Central.
…ess up loading dependencies from the production artifact repository.
…n-central Publish artifact SNAPSHOTs to Maven Central
…ncies Update dependencies for Summer 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project for the Summer 2025 offering by upgrading Java to version 21, bumping dependency and plugin versions, and switching to the Maven Central Snapshot repository. The changes include removal of legacy archetype.xml files, addition of requiredProperties in archetype-metadata.xml files, and updates in parent and module pom.xml files along with adjustments in the GitHub Actions workflow.
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects-parent/archetypes-parent/apptbook-web-archetype/src/main/resources/META-INF/maven/archetype.xml | Removed legacy archetype definition |
| projects-parent/archetypes-parent/apptbook-web-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml | Added requiredProperties for new configuration |
| projects-parent/archetypes-parent/apptbook-web-archetype/pom.xml | Updated parent and artifact versions |
| projects-parent/archetypes-parent/apptbook-archetype/src/main/resources/archetype-resources/pom.xml | Updated dependency versions and parent reference |
| projects-parent/archetypes-parent/apptbook-archetype/src/main/resources/META-INF/maven/archetype.xml | Removed legacy archetype definition |
| projects-parent/archetypes-parent/apptbook-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml | Added requiredProperties for new configuration |
| projects-parent/archetypes-parent/apptbook-archetype/pom.xml | Updated parent and artifact versions |
| projects-parent/archetypes-parent/airline-web-archetype/src/main/resources/archetype-resources/pom.xml | Upgraded dependency versions |
| projects-parent/archetypes-parent/airline-web-archetype/src/main/resources/META-INF/maven/archetype.xml | Removed legacy archetype definition |
| projects-parent/archetypes-parent/airline-web-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml | Added requiredProperties for new configuration |
| projects-parent/archetypes-parent/airline-web-archetype/pom.xml | Updated parent and artifact versions |
| projects-parent/archetypes-parent/airline-archetype/src/main/resources/archetype-resources/pom.xml | Switched snapshot repository URL and updated dependency versions |
| projects-parent/archetypes-parent/airline-archetype/src/main/resources/META-INF/maven/archetype.xml | Removed legacy archetype definition |
| projects-parent/archetypes-parent/airline-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml | Added requiredProperties for new configuration |
| projects-parent/archetypes-parent/airline-archetype/pom.xml | Updated parent, artifact versions, and snapshot repository configuration |
| pom.xml | Upgraded Java version, dependency/plugin versions, and replaced OSSRH staging with central publishing |
| grader/pom.xml | Updated parent and dependency versions |
| family/pom.xml | Updated parent, artifact, and dependency versions |
| examples/pom.xml | Updated parent and dependency versions |
| .github/workflows/maven.yml | Simplified Java version matrix to use Java 21 |
Comments suppressed due to low confidence (3)
projects-parent/archetypes-parent/apptbook-web-archetype/src/main/resources/META-INF/maven/archetype.xml:1
- The archetype.xml file has been completely removed. Please ensure that any tooling or processes that depend on this legacy file are updated to use the new archetype-metadata.xml format.
<?xml version="1.0" encoding="UTF-8"?><archetype> ...
projects-parent/archetypes-parent/airline-web-archetype/src/main/resources/META-INF/maven/archetype.xml:1
- The removal of this archetype.xml file appears intentional; please verify that legacy processes or integrations that expect this file are updated accordingly.
<?xml version="1.0" encoding="UTF-8"?><archetype> ...
projects-parent/archetypes-parent/airline-archetype/src/main/resources/archetype-resources/pom.xml:101
- The Maven Snapshot repository URL has been updated. It would be good to double-check that this URL is correct and accessible across all modules.
<url>https://central.sonatype.com/repository/maven-snapshots/</url>
.github/workflows/maven.yml
Outdated
| strategy: | ||
| matrix: | ||
| java: [ '17', '22' ] | ||
| java: [ '21' ] |
There was a problem hiding this comment.
[nitpick] The workflow matrix now includes only a single Java version. Consider simplifying the workflow configuration if supporting multiple versions is no longer necessary.
Collaborator
Author
There was a problem hiding this comment.
Can you check this again? I re-added a second version of Java.
… plugin used by other project archetypes.
Support Java 24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the following issues for the Summer 2025 offering of The Joy of Coding