add codecov token secret to CI.yml#525
Merged
ViralBShah merged 1 commit intoJuliaDSP:masterfrom Feb 5, 2024
Merged
Conversation
also added CODECOV_TOKEN dependabot repository secret
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 97.29% 97.46% +0.17%
==========================================
Files 18 18
Lines 3105 3080 -25
==========================================
- Hits 3021 3002 -19
+ Misses 84 78 -6 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Do we want CI to fail if the Codecov upload errors? |
Contributor
|
I don't think we want CI to fail in case codecov upload errors. Let's see how it works out for the foreseeable future, and if we need to be more strict. |
ViralBShah
approved these changes
Feb 5, 2024
Contributor
|
It seems that the general consensus is that we should use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added CODECOV_TOKEN Dependabot repository secret