CI: Fix Codecov

[oscardssmith]

No description provided.

[devmotion]

The workflow config looks good. Based on the CI logs (https://github.com/JuliaMath/IntegerMathUtils.jl/actions/runs/7786813263/job/21232481397?pr=14#step:8:31) I assume you haven't added the token as a Github secret yet?

[oscardssmith]

That is correct. Do I want to add them to actions/repository secrets?

[devmotion]

Yes, as a new repository secret: https://docs.codecov.com/docs/adding-the-codecov-token#github-actions (these instructions use the token as an environment variable in CI, but one can just directly add it as token: https://github.com/codecov/codecov-action?tab=readme-ov-file#usage)

[DilumAluthge]

I personally would recommend that you keep fail_ci_if_error: true.

That way, if there is a problem with Codecov, you get notified immediately.

[oscardssmith]

yeah. I was trying to delete it to see if it would fix things. I'm very confused as to why this doesn't work but JuliaDSP/DSP.jl#525 does. I'd be interested if you know what the difference is.

[DilumAluthge]

In order to get coverage for Julia packages, we rely on Codecov's support for lcov.info files. Maybe v4 of their action broke support for lcov.info files?

For debugging, let's find all lcov.info files, and maybe head them to make sure they look correct.

[DilumAluthge]

From the logs:

error - 2024-02-05 20:32:55,223 -- Commit creating failed: {"error": "Server Error (500)"}

Is this a 500 error from the Codecov server or from the GitHub server?

Either way, 500 implies the problem is on the server's side, not our side.

[staticfloat]

The macOS build is successfully uploading.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c4c52ee). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage        ?   89.06%           
=======================================
  Files           ?        1           
  Lines           ?       64           
  Branches        ?        0           
=======================================
  Hits            ?       57           
  Misses          ?        7           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DilumAluthge]

It was probably a transient server-side error on the Codecov servers?

[DilumAluthge]

@devmotion Since we're already working on the CI config here, I wonder if this is a good opportunity to do the following:

1. Add a finalize job.
2. Set up GitHub Merge Queue on this repo.

[DilumAluthge]

(I can enable merge queue in the GitHub repo settings, when we are ready.)

[oscardssmith]

this is ready to merge, right?

[oscardssmith]

thanks for the help!