Conversation
github-actions
bot
added
the
needs version bump
github-actions
bot
removed
the
needs version bump
github-actions
bot
added
the
needs version bump
devmotion
approved these changes
Jul 1, 2022
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
This looks good to me. Mainly a version bump seems to be missing?
I think this would fix some downstream issues in Zygote on newer Julia versions. These issues popped up also in downstream packages such as JuliaGaussianProcesses/ApproximateGPs.jl#135. I assume this PR might fix them since one issue seems to be that currently the rules for cholesky in ChainRules are not picked up (see e.g. https://github.com/FluxML/Zygote.jl/runs/7124557589?check_suite_focus=true#step:6:1540).
|
Closes #647 |
|
Should also fix current Zygote failure on |
github-actions
bot
added
needs version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #477 by adopting a similar approach as #434, except that it uses a type union to still support the old syntax. This will need to be removed for future Julia versions when the deprecated syntax is removed.