Store graph in result to allow generic matrices#133
Merged
amontoison merged 4 commits intomainfrom Oct 2, 2024
Merged
Conversation
gdalle
commented
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 851 870 +19
=========================================
+ Hits 851 870 +19 ☔ View full report in Codecov by Sentry. |
gdalle
commented
Oct 2, 2024
gdalle
commented
Oct 2, 2024
gdalle
commented
Oct 2, 2024
Contributor
Benchmark Results
|
amontoison
reviewed
Oct 2, 2024
Collaborator
|
Except two small comments, it's LGTM. |
Member
Author
|
I think both those comments are resolved? |
amontoison
reviewed
Oct 2, 2024
Collaborator
Tu peux merge si tu veux après |
amontoison
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #126, fix #131
Before this PR, the
resulttype would always store aSparseMatrixCSCand forget the initial matrixA. Now it stores both the initial matrixAand theAdjacencyGraphorBipartiteGraphused for coloring, which contains the sparse conversion. This has two main advantages:BipartiteGraphsimilar(A)instead ofsimilar(S), which makes more sense and paves the way for structured matricesI also remove some eltype constraints on
AandBwhich were not necessary. For instance, ifeltype(B) == Float32andeltype(A) == Float64, we can decompress fromBtoAwithout issue.