**BREAKING** Type Stability for MOInputs#405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 52 52
Lines 1199 1199
=======================================
Hits 1112 1112
Misses 87 87
Continue to review full report at Codecov.
|
|
Seems fine to me. |
|
@theogf @st-- there are a number of other things that we've wanted to address in the next breaking release for a while: #338 I don't have time to push these through right now, so I'm going to hold off on merging this until we've got them in place, either in this PR or another, so that we don't have to block patch releases on master. |
|
Should we generally have a branch |
|
Closed in favour of #465 , which is non-breaking |
Summary
Make input collection types for isotopic multi-output things type stable.
Proposed changes
Change the
Integertype constraint inMOInputIsotopicByFeaturesandMOInputIsotopicByOutputswithInts.What alternatives have you considered?
Could have parametrised the type to allow any
Integer, but I think this is probably fine.Breaking changes
If anyone is currently using anything other than an
Intto specify the number of outputs, they'll need to change it to anInt. I can't imagine that this happens very often, so effects should be minimal.