Update README.md #99
Closed
Update README.md #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `Graphs.jl` examples to `LightGraphs.jl`
Contributor
Author
|
@simonschoelly - mind taking a look? I'm not at a system where I can test the LG changes but I think they're correct. |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 33.54% 27.29% -6.25%
==========================================
Files 9 8 -1
Lines 474 392 -82
==========================================
- Hits 159 107 -52
+ Misses 315 285 -30
Continue to review full report at Codecov.
|
Contributor
Author
|
I didn't do anything that would've affected codecov. |
matbesancon
reviewed
Jan 22, 2020
| using Graphs | ||
| nodelabel = [1:num_vertices(g)] | ||
| using LightGraphs | ||
| nodelabel = [vertices(g)] |
Member
There was a problem hiding this comment.
Suggested change
| nodelabel = [vertices(g)] | |
| nodelabel = collect(vertices(g)) |
matbesancon
reviewed
Jan 22, 2020
| ## Draw edge labels | ||
| ```julia | ||
| edgelabel = [1:Graphs.num_edges(g)] | ||
| edgelabel = [1:ne(g)] |
Member
There was a problem hiding this comment.
Suggested change
| edgelabel = [1:ne(g)] | |
| edgelabel = collect(1:ne(g)) |
matbesancon
reviewed
Jan 22, 2020
| ## Adjust edge labels | ||
| ```julia | ||
| edgelabel = [1:Graphs.num_edges(g)] | ||
| edgelabel = [1:ne(g)] |
Member
There was a problem hiding this comment.
Suggested change
| edgelabel = [1:ne(g)] | |
| edgelabel = collect(1:ne(g)) |
matbesancon
reviewed
Jan 22, 2020
| @@ -121,7 +121,7 @@ gplot(g, layout=spectral_layout) | |||
| ```julia | |||
| nlist = Array(Vector{Int}, 2) # two shells | |||
| nlist[1] = [1:5] # first shell | |||
Member
There was a problem hiding this comment.
Suggested change
| nlist[1] = [1:5] # first shell | |
| nlist[1] = collect(1:5) # first shell |
matbesancon
reviewed
Jan 22, 2020
| nlist = Array(Vector{Int}, 2) # two shells | ||
| nlist[1] = [1:5] # first shell | ||
| nlist[2] = [6:num_vertices(g)] # second shell | ||
| nlist[2] = [6:nv(g)] # second shell |
Member
There was a problem hiding this comment.
Suggested change
| nlist[2] = [6:nv(g)] # second shell | |
| nlist[2] = collect(6:nv(g)) # second shell |
matbesancon
reviewed
Jan 22, 2020
| @@ -121,7 +121,7 @@ gplot(g, layout=spectral_layout) | |||
| ```julia | |||
| nlist = Array(Vector{Int}, 2) # two shells | |||
Member
There was a problem hiding this comment.
Suggested change
| nlist = Array(Vector{Int}, 2) # two shells | |
| nlist = Vector{Vector{Int}}(undef, 2) # two shells |
Member
|
Didn't see this PR, so I made similar changes in #104 . Therefore I am closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Graphs.jlexamples toLightGraphs.jl