Update readme #104
Merged
Update readme #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The graphfamous function of this package was deprecated a while ago and the karate was moved to LightGraphs.
This readme still used mostly Graphs.jl instead of LightGraphs.jl. As the former package is deprecated and GraphPlots.jl does not work with it anymore, every occurrence of Graphs has changed to LightGraphs. Some functions functions such as num_vertices or out_degree had to be changed for that.
For drawing a graph to a file, it is not necessary to import Cairo before importing Compose.
sbromberger
approved these changes
Mar 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
======================================
Coverage 34.1% 34.1%
======================================
Files 9 9
Lines 478 478
======================================
Hits 163 163
Misses 315 315Continue to review full report at Codecov.
|
Closed
Contributor
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme for this project is fairly outdated and still relied mostly on Graphs.jl instead of LightGraphs.jl, so this PR changes the code, so that it works as least.