Skip to content

Conversation

@DilumAluthge
Copy link
Member

Let's see what breaks.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Sep 9, 2021

@ViralBShah You'll need to approve workflows on this PR, since I've never contributed to this repo before.

If you want, you can relax that restriction by going to https://github.com/organizations/JuliaMath/settings/actions and, under the "Fork pull request workflows from outside collaborators" section, click the "Require approval for first-time contributors who are new to GitHub" option and click save.

@ViralBShah
Copy link
Member

It's hard to tell what is actually breaking. Is it truly getting a 32-bit windows box?

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Sep 9, 2021

I don't think GHA actually has 32-bit Windows VMs. We'll still be in a 64-bit Windows VM, but we can hopefully still use a 32-bit compiler.

I'm going to try some of the advice from this thread: actions/runner-images#2549

You'll need to re-approve the workflows.

@jeremyd2019
Copy link
Contributor

I would recommend using the setup-msys2 action, but I don't know if that's reasonably possible in a single job matrixed with other OSes, I've generally seen a separate 'windows' job with a matrix for the different compilers (32/64-bit gcc/clang). Also, if you want to be able to build for aarch64 using mingw, https://github.com/mstorsjo/llvm-mingw is probably the best choice. I've been working on an arm64 environment for msys2, but currently that's all native, which currently means you'd need a self-hosted windows arm64 runner for github actions ☹️(actions/runner#785 )

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Sep 9, 2021

I'm hoping that the latest fix I pushed will work. If not, I'll try the setup-msys2 action. We can choose to run it only on the Windows x86 job.

@jeremyd2019
Copy link
Contributor

I'm not sure that relying on mingw toolchains from the pre-installed msys2 is going to continue to work once they update to the 2022 image. actions/runner-images#3949 (bottom of the table)

@DilumAluthge
Copy link
Member Author

Ooof. In the short-term, we can just pin to the 2019 image. But you're right, it looks like we'll eventually need to use https://github.com/msys2/setup-msys2 for the 2022 image.

@DilumAluthge
Copy link
Member Author

Thanks for the link to that table!

@ViralBShah
Copy link
Member

ViralBShah commented Sep 9, 2021

Even with setup-msys2, I could only get 64-bit windows working. If you see my PR that I merged yesterday it has experimentation and logs with trying to enable msys2.

@jeremyd2019
Copy link
Contributor

I think what's happening here is you can't really link with -nodefaultlibs on mingw-w64 (well you can, but there's a set of default libs you need). See https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-openlibm/01-mingw-build.patch for what they did to get it building there.

@ViralBShah
Copy link
Member

Seems like we should adopt that patch from mingw.

@jeremyd2019
Copy link
Contributor

I opened #243, don't know if that's preferred. There are a few test failures that need figuring out though.

@ViralBShah ViralBShah closed this Sep 9, 2021
@DilumAluthge DilumAluthge deleted the dpa/ci-windows-x86 branch September 9, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants