-
Notifications
You must be signed in to change notification settings - Fork 153
msys2 ci #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msys2 ci #243
Conversation
|
lgamma is in libmingwex, one of the default libs. But, it should only be pulled in if the symbol is needed by something, and that shouldn't be if openlibm is providing it. |
|
It could also be that it's pulling in mingw's signgam and openlibm's lgamma. I'll have to investigate it locally to find out exactly what's going on |
That seems to be the case, lgamma is exported from openlibm, but signgam is not. Will probably have a patch quickly |
it needs to be exported from the DLL also
While there are function export thunks in the import library that allow the linker to do the right thing for functions even if this is not set, it is required for the linker to do the right thing with variables being imported from a DLL (namely, signgam)
|
couple more missing OLM_DLLEXPORTs it looks like |
seems this whole header was overlooked
include openlibm_defs.h for OLM_DLLEXPORT
|
Finally all green! Sorry for the bit of a mess on this PR. I can squash some commits, and/or split the CI and fixes into separate PRs if preferred. |
|
oh, the i686 clang fix I made in #242 uses is for |
|
Don't worry about the squashing. We can squash and merge. |
|
I think we don't need to have the experimental support in #242 in CI - just need to make sure it doesn't break anything else. These CI greens are perfect for that. |
|
Thank you @jeremyd2019! |
Adds a separate job using setup-msys2 to test all currently available MinGW-w64 environments there.
These currently fail a few tests relating to signgam from lgamma. I'm not sure if that's due to it calling mingw-w64's variant of lgamma or what.