prefix symbols with _ for 32-bit x86 Windows #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
|
Can you rebase this on master now so that we can get the full CI run? |
In a case that I believe can only be hit for Clang i686-*-windows-gnu (AKA MinGW), symbols in asm need to be prefixed with `_`. Fixes #237
Member
|
So nice to have the CI. Thanks @jeremyd2019. |
jeremyd2019
added a commit
to jeremyd2019/MINGW-packages
that referenced
this pull request
Sep 9, 2021
The mingw-build patch was subsumed by upstream commit JuliaMath/openlibm@60dec83 (I stripped the patch to the github workflow as it didn't exist in the release and isn't necessary for building). The clang symbol patch was added upstream in JuliaMath/openlibm#242
jeremyd2019
added a commit
to jeremyd2019/MINGW-packages
that referenced
this pull request
Sep 10, 2021
The mingw-build patch was subsumed by upstream commit JuliaMath/openlibm@60dec83 (I stripped the patch to the github workflow as it didn't exist in the release and isn't necessary for building). The clang symbol patch was added upstream in JuliaMath/openlibm#242 enable tests They actually pass now, so don't `|| true` them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #238
In a case that I believe can only be hit for Clang i686-*-windows-gnu (AKA MinGW), symbols in asm need to be prefixed with
_. Fixes #237