feat: Add search for rc files#220
Merged
LeonMatthesKDAB merged 3 commits intoKDAB:mainfrom Dec 13, 2024
Merged
Conversation
LeonMatthesKDAB
suggested changes
Nov 28, 2024
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Overall the change is okay, but the SearchableViewInterface name is confusing, as this class implements "Find", not "Search" and actually isn't an "interface".
There are no good reasons to keep it separate, and this will allow to add search using the new search API for views.
This way the class is view agnostic, and could be used for other things than just table (but could be used for tree).
For now, only search inside the list of data IDs. We may extend this later on if useful/needed. Fix KDAB#25
LeonMatthesKDAB
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, only search inside the list of data IDs.
We may extend this later on if useful/needed.
To do that, I had to move the rcui code inside the gui library, so I can use the FindInterface.
Fix #25