Conversation
Scheduler: paritytech/substrate#10356 OriginPriviligeCmp: paritytech/polkadot#4166
Contributor
Author
|
/bench runtime spiritnet-runtime pallet_preimage |
|
Error running benchmark: wf-polkadot-0.9.16 stdoutFrom https://github.com/KILTprotocol/mashnet-node * branch develop -> FETCH_HEAD |
ntn-x2
approved these changes
Feb 2, 2022
Contributor
ntn-x2
left a comment
There was a problem hiding this comment.
A super minor nitpick, but otherwise LGMT!
weichweich
reviewed
Feb 3, 2022
weichweich
reviewed
Feb 3, 2022
Contributor
Author
|
Since it has been running smoothly on the local setup, I will merge now and test on Spiritnet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#1793
palletsdirectoryAllPalletshook which executed pallets in the reverse order of their definition withinconstruct_runtime!with the exception thatSystemwas always executed firstAllPalletsWithSystem, we have to reorder some of our pallets, see 625df70 and 6363a5cstate_versionto runtime (Substrate #9732)#[pallet::without_storage_info], we skip generating storage info and can worry about this change later. It will be required for PoV benchmarksMaxEncodedLenwherever necessaryToDo
AllPalletsReversedWithSystemFirstwhich keeps the exact same order. Wondering why other teams switched toAllPalletsWithSystemwithout any reordering.try-runtimeagainst Peregrine-stgtry-runtimeagainst SpiritnetChecklist:
array[3]useget(3), ...)