This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Insufficient asset quota and deposits#10382
Merged
Conversation
adoerr
approved these changes
Nov 28, 2021
Contributor
adoerr
left a comment
There was a problem hiding this comment.
beefy-mmr, beefy and merkle-mountain-range LGTM
Contributor
|
The impression I have is that the new ExistenceReason enum is designed to avoid migrations with the current boolean type right? So my assumption is that the PR does not imply data migrations? |
gui1117
reviewed
Nov 30, 2021
gui1117
reviewed
Nov 30, 2021
gui1117
reviewed
Nov 30, 2021
gui1117
reviewed
Nov 30, 2021
Contributor
|
the trait FrozenBalance says: I think it needs to be updated. |
apopiak
reviewed
Nov 30, 2021
shawntabrizi
reviewed
Dec 1, 2021
shawntabrizi
reviewed
Dec 1, 2021
Member
Author
|
@thiolliere @shawntabrizi @KiChjang Updated. |
Contributor
It is now good with #10431 |
Member
Author
|
@thiolliere An approval would be good :) |
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
* Allow asset accounts to exist by deposit * Place limit on consumers (and therefore freebie asset accounts) * Maximum number of assets * Fixes * Fixes * Formatting * Docs * Formatting * Destroyed assets are properly tidied * Update frame/assets/src/types.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Docs * Docs * Formatting * Docs * Docs * Fixes * Fixes Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
HCastano
added a commit
to paritytech/canvas
that referenced
this pull request
Jan 8, 2022
cmichi
pushed a commit
to paritytech/canvas
that referenced
this pull request
Jan 10, 2022
* Bump Cumulus, Polkadot, and Substrate Also bumps some other depenencies * Remove duplicate `polkadot` dependency * Update `service.rs` Changes related to: paritytech/cumulus#835 * Update `command.rs` * Add `AddressGenerator` config type From: paritytech/substrate#10521 * Allow Root to execute overweight XCMP messages From: paritytech/cumulus#799 * Add `header` argument to `collect_collation_info` From: paritytech/cumulus#882 * Update Cumulus and friends again * Add Fork ID to genesis config paritytech/cumulus#870 * Add `state_version` field paritytech/substrate#9732 * Add `MaxConsumers` config parameter paritytech/substrate#10382 * Update Substrate compatibility note in README
4 tasks
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jan 31, 2022
14 tasks
26 tasks
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 9, 2022
* chore: bump Polkadot dependencies to v0.9.16 * refactor: use AllPalletsWithSystem hook * chore: remove crowdloan pallet * fix: apply no DefaultAccount check * fix: switch to default MaxEncodedLen paritytech/substrate#10662 * fix: apply asset quota + runtime state_version quota: paritytech/substrate#10382 state: paritytech/substrate#9732 * fix: Preimage registrar and Scheduler integration Scheduler: paritytech/substrate#10356 OriginPriviligeCmp: paritytech/polkadot#4166 * fix: OrderedSet * fix: apply new fork_id to chainspecs paritytech/substrate#10463 * fix: apply no default account for SudoConfig * fix: apply name changes for GrandPa paritytech/substrate#10463 * fix: EnsureOneOf paritytech/substrate#10379 * fix: preimage weights * fix: parachain client * fix: clippy copied weights * fix: bump deps * tests: attempt staking fix * bench: attempt to fix default accountid for dids * fix: staking unit test pallet order execution * fix: did unit benchmarks * fix: fmt * fix: revert to old hook order execution * bench: run manually for preimage + scheduler * fix: only import TaskManager for try-runtime feature * fix: use correct scheduler migration + add logs * refactor: use explicit para runtime executors * fix: apply code review by @Diiaablo95 * chore: apply suggestion from @weichweich review * chore: bump deps * fix: deps
2 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Allow asset accounts to exist by deposit * Place limit on consumers (and therefore freebie asset accounts) * Maximum number of assets * Fixes * Fixes * Formatting * Docs * Formatting * Destroyed assets are properly tidied * Update frame/assets/src/types.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Docs * Docs * Formatting * Docs * Docs * Fixes * Fixes Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
aurexav
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
aurexav
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Allow asset accounts to exist by deposit * Place limit on consumers (and therefore freebie asset accounts) * Maximum number of assets * Fixes * Fixes * Formatting * Docs * Formatting * Destroyed assets are properly tidied * Update frame/assets/src/types.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Docs * Docs * Formatting * Docs * Docs * Fixes * Fixes Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10378
Polkadot companion: paritytech/polkadot#4390
Cumulus companion: paritytech/cumulus#804
Make two changes:
touchfunction and refunded by using the newrefundfunction.Additional considerations
Consider the possibility of requiring
touchto be used to receive any insufficient asset, which would mean the user would have to take active measures to receive an asset but that they could not gather consumer references inadvertently.Downstream Code Migration
The System config trait
frame_system::Confignow has an additional itemMaxConsumers. e.g.The Assets config trait
frame_assets::Confignow has an additional itemAssetAccountDeposit. e.g.