This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Improve pallet asset doc#10431
Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom Dec 9, 2021
Merged
Conversation
gui1117
added
B0-silent
xlc
reviewed
Dec 7, 2021
| /// | ||
| /// # Warning | ||
| /// | ||
| /// This function must never access storage of pallet asset. This function is called while some |
shawntabrizi
approved these changes
Dec 9, 2021
emostov
approved these changes
Dec 9, 2021
Contributor
|
bot merge |
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10391
For the doc of
frozen_balanceI actually can't really understand the doc, I tried to do what I think is the current implementation and in regards to what is discussed in the issue #10391For the doc of
diedI think we can improve the implementation in order not to have this error prone API. But I just documented the current behavior.