This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Support overweight messages in XCMP queue#799
Merged
Conversation
apopiak
reviewed
Nov 25, 2021
Contributor
apopiak
left a comment
apopiak
left a comment
There was a problem hiding this comment.
I would like to see a test that tries to process an overweight XCM and then calls the service_overweight functionality.
apopiak
reviewed
Nov 26, 2021
Comment on lines
+71
to
+82
| pub fn migrate_to_v1<T: Config>() -> Weight { | ||
| let translate = |pre: v0::QueueConfigData| -> super::QueueConfigData { | ||
| super::QueueConfigData { | ||
| suspend_threshold: pre.suspend_threshold, | ||
| drop_threshold: pre.drop_threshold, | ||
| resume_threshold: pre.resume_threshold, | ||
| threshold_weight: pre.threshold_weight, | ||
| weight_restrict_decay: pre.weight_restrict_decay, | ||
| xcmp_max_individual_weight: super::QueueConfigData::default() | ||
| .xcmp_max_individual_weight, | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
Would it make sense to parameterize the migration function to take a xcmp_max_individual_weight so that people can migrate to whatever config value they want?
Alternatively we'd want to expose some knob somewhere to update the queue config, no?
Maybe a candidate for a follow-up issue?
apopiak
approved these changes
Nov 26, 2021
Contributor
apopiak
left a comment
apopiak
left a comment
There was a problem hiding this comment.
LGTM, I'll let Gav address the question in code
KiChjang
commented
Nov 27, 2021
gavofyork
reviewed
Dec 8, 2021
gavofyork
approved these changes
Dec 8, 2021
Member
|
Looks reasonable. |
shawntabrizi
approved these changes
Dec 9, 2021
KiChjang
added
A0-pleasereview
B0-silent
HCastano
added a commit
to paritytech/canvas
that referenced
this pull request
Jan 8, 2022
cmichi
pushed a commit
to paritytech/canvas
that referenced
this pull request
Jan 10, 2022
* Bump Cumulus, Polkadot, and Substrate Also bumps some other depenencies * Remove duplicate `polkadot` dependency * Update `service.rs` Changes related to: paritytech/cumulus#835 * Update `command.rs` * Add `AddressGenerator` config type From: paritytech/substrate#10521 * Allow Root to execute overweight XCMP messages From: paritytech/cumulus#799 * Add `header` argument to `collect_collation_info` From: paritytech/cumulus#882 * Update Cumulus and friends again * Add Fork ID to genesis config paritytech/cumulus#870 * Add `state_version` field paritytech/substrate#9732 * Add `MaxConsumers` config parameter paritytech/substrate#10382 * Update Substrate compatibility note in README
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation follows closely to the UMP overweight message handling, as seen here in this PR.
Fixes paritytech/srlabs_findings#145.