Skip to content

feat: emit additional event on reset_team#874

Merged
rflechtner merged 4 commits intobonded-coins-audit-fixesfrom
audit-issue-17
Mar 14, 2025
Merged

feat: emit additional event on reset_team#874
rflechtner merged 4 commits intobonded-coins-audit-fixesfrom
audit-issue-17

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Mar 11, 2025

fixes KILTProtocol/ticket#3813

Following recommendations by OAK, this adds another event to be emitted on calling reset_team. This is emitted in addition to the events emitted by the assets pallet itself.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner marked this pull request as ready for review March 12, 2025 10:54
@rflechtner rflechtner requested review from abdulmth and ntn-x2 March 12, 2025 11:14
@rflechtner
Copy link
Contributor Author

Feedback about the necessity of this change is welcomed on the linked ticket (https://github.com/KILTprotocol/ticket/issues/3813)

@rflechtner rflechtner merged commit 4b800ee into bonded-coins-audit-fixes Mar 14, 2025
13 of 15 checks passed
@rflechtner rflechtner deleted the audit-issue-17 branch March 14, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants