Skip to content

feat: emit additional event on reset_team #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rflechtner merged 4 commits into from
Mar 14, 2025
Merged

feat: emit additional event on reset_team #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c8e468
feat: emit additional event on reset_team
rflechtner Mar 11, 2025
469cc93
chore: rename event to TeamChanged
rflechtner Mar 11, 2025
36c17f1
fix: test
rflechtner Mar 12, 2025
e5661a0
refactor: unpack team members on event
rflechtner Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions pallets/pallet-bonded-coins/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ pub mod pallet {
id: T::PoolId,
manager: Option<T::AccountId>,
},
/// The asset managing team of a pool has been reset.
TeamChanged {
id: T::PoolId,
admin: T::AccountId,
freezer: T::AccountId,
},
}

#[pallet::error]
Expand Down Expand Up @@ -501,7 +507,7 @@ pub mod pallet {
ensure!(pool_details.is_manager(&who), Error::<T>::NoPermission);
ensure!(pool_details.state.is_live(), Error::<T>::PoolNotLive);

let pool_id_account = pool_id.into();
let pool_id_account = pool_id.clone().into();

let PoolManagingTeam { freezer, admin } = team;

Expand All @@ -513,7 +519,15 @@ pub mod pallet {
pool_id_account.clone(),
freezer.clone(),
)
})
})?;

Self::deposit_event(Event::TeamChanged {
id: pool_id,
admin,
freezer,
});

Ok(())
}

/// Resets the manager of a pool. The new manager will be set to the
Expand Down
32 changes: 31 additions & 1 deletion pallets/pallet-bonded-coins/src/tests/transactions/reset_team.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use crate::{
mock::{runtime::*, *},
traits::ResetTeam,
types::{PoolManagingTeam, PoolStatus},
AccountIdOf, Error as BondingPalletErrors,
AccountIdOf, Error as BondingPalletErrors, Event,
};

#[test]
Expand Down Expand Up @@ -55,6 +55,16 @@ fn resets_team() {
1
));

// Ensure the event is emitted
System::assert_has_event(
Event::TeamChanged {
id: pool_id.clone(),
admin: ACCOUNT_00,
freezer: ACCOUNT_01,
}
.into(),
);

assert_eq!(Assets::admin(DEFAULT_BONDED_CURRENCY_ID), Some(ACCOUNT_00));
assert_eq!(Assets::freezer(DEFAULT_BONDED_CURRENCY_ID), Some(ACCOUNT_01));
assert_eq!(Assets::owner(DEFAULT_BONDED_CURRENCY_ID), Some(pool_id.clone()));
Expand Down Expand Up @@ -106,6 +116,16 @@ fn resets_owner_if_changed() {
1
));

// Ensure the event is emitted
System::assert_has_event(
Event::TeamChanged {
id: pool_id.clone(),
admin: pool_id.clone(),
freezer: pool_id.clone(),
}
.into(),
);

assert_eq!(Assets::admin(DEFAULT_BONDED_CURRENCY_ID), Some(pool_id.clone()));
assert_eq!(Assets::freezer(DEFAULT_BONDED_CURRENCY_ID), Some(pool_id.clone()));
assert_eq!(Assets::owner(DEFAULT_BONDED_CURRENCY_ID), Some(pool_id.clone()));
Expand Down Expand Up @@ -145,6 +165,16 @@ fn resets_team_for_all() {
2
));

// Ensure the event is emitted
System::assert_has_event(
Event::TeamChanged {
id: pool_id.clone(),
admin: ACCOUNT_00,
freezer: ACCOUNT_01,
}
.into(),
);

assert_eq!(Assets::admin(currencies[0]), Some(ACCOUNT_00));
assert_eq!(Assets::freezer(currencies[0]), Some(ACCOUNT_01));
assert_eq!(Assets::owner(currencies[0]), Some(pool_id.clone()));
Expand Down
Loading