Issue #43: Bug: uart reception crashes on rx line fault#46
Draft
hasslesstech wants to merge 9 commits intomainfrom
Draft
Issue #43: Bug: uart reception crashes on rx line fault#46hasslesstech wants to merge 9 commits intomainfrom
hasslesstech wants to merge 9 commits intomainfrom
Conversation
…save some new fields
…eading to issue reappearing
hasslesstech
force-pushed
the
43-ecu-stm32-bug-uart-reception-crashes-on-rx-line-fault
branch
from
431a04f to
c456e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout in
UARTTransport_receivefunction that is triggered whenever no packets are added to the queue for over 50 ms. In case the timeout is reached, this function calls a new driver API function,drvUart_restart_receiver().drvUart_restart_receiver()checks if the DMA is active and if it is not, starts it back up. Reception is restarted every time it crashes regardless of the reason for the crash. This allows for a timely and reliable recovery in case of any possible line failure.At the same time, the function does not make unnecessary calls if the reception is active and no packets are being received.