[cmake] require >= Vulkan Headers version in VULConfig.cmake #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
todo: - maybe just use var substitution? because fetchcontent is incredible - test this - sign the commit I don't have an environment available to test this yet
crueter
changed the title
| include(CMakeFindDependencyMacro) | ||
| # NOTE: Because VulkanHeaders is a PUBLIC dependency it needs to be found prior to VulkanUtilityLibraries | ||
| find_dependency(VulkanHeaders REQUIRED) | ||
| find_dependency(VulkanHeaders @PROJECT_VERSION@ REQUIRED) |
Collaborator
There was a problem hiding this comment.
Any particular reason to use @PROJECT_VERSION@ instead of ${PROJECT_VERSION}? Unless the @@ is required, I'd like to use ${} to make the file more self consistent.
Contributor
Author
There was a problem hiding this comment.
Oh, I actually meant to do that but forgot about it :P
Contributor
Author
There was a problem hiding this comment.
Actually, I remember why; CMake doesn't parse that string so we have to use @@. Otherwise it turns into:
charles-lunarg
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #315