Skip to content

[cmake] require >= Vulkan Headers version in VULConfig.cmake #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charles-lunarg merged 1 commit into from
Nov 12, 2025
Merged

[cmake] require >= Vulkan Headers version in VULConfig.cmake #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ if (VUL_ENABLE_INSTALL)
file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/VulkanUtilityLibrariesConfig.cmake.in" [=[
include(CMakeFindDependencyMacro)
# NOTE: Because VulkanHeaders is a PUBLIC dependency it needs to be found prior to VulkanUtilityLibraries
find_dependency(VulkanHeaders REQUIRED)
find_dependency(VulkanHeaders @PROJECT_VERSION@ REQUIRED)
Copy link
Collaborator

@charles-lunarg charles-lunarg Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to use @PROJECT_VERSION@ instead of ${PROJECT_VERSION}? Unless the @@ is required, I'd like to use ${} to make the file more self consistent.

Copy link
Contributor Author

@crueter crueter Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I actually meant to do that but forgot about it :P

Copy link
Contributor Author

@crueter crueter Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I remember why; CMake doesn't parse that string so we have to use @@. Otherwise it turns into:

image


@PACKAGE_INIT@

Expand Down