Open
Conversation
Adds subsample_volume() to util.py and subsample_dwi() to dwi.py so that example notebooks can toggle quick low-resolution runs via SUBSAMPLE=True. Also removes misleading "open .py directly" section from notebooks README. Closes #124 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The install-on-import pattern using pip doesn't work with uv-managed venvs. Declare the dependency properly and just import it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ebrahimebrahim
force-pushed
the
add-downsampling-to-demo-notebooks
branch
from
8ce1025 to
5699b96
Compare
sadhana-r
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI generated PR description
Summary
SUBSAMPLE = Truetoggle toexample-pipeline.pyandexample-group-template.pyso users can quickly run through the notebooks at lower spatial resolutionsubsample_volume()inutil.py(stride-based, takes every Nth voxel) andsubsample_dwi()indwi.pyopenneuro-pyto the[notebooks]dependency group (the old pip-install-on-import pattern doesn't work with uv)notebooks/README.mdHow subsampling works
Stride-based:
arr[::factor, ::factor, ::factor]on the 3 spatial dims, affine scaled to match. Not interpolated resampling — just a quick way to shrink data for trying things out.Closes #124