Exit with error from test-wheel.bash if a background task failed.#8
Merged
josephbirkner merged 4 commits intomainfrom Aug 10, 2023
Merged
Exit with error from test-wheel.bash if a background task failed.#8josephbirkner merged 4 commits intomainfrom
josephbirkner merged 4 commits intomainfrom
Conversation
Collaborator
|
Nice 💯 Maybe let's also add |
Remove exit 0 from test-wheel.bash and enable set -e
Collaborator
|
Tested by ensuring that both background and foreground task failures cascade to a test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background tasks were killed in the trap section without checking their exit codes, so any errors were ignored.
This PR was tested with mapget's
test-cli-datasource-exetest: it now fails if the script specified in the background task does not exist.