Skip to content

Exit with error from test-wheel.bash if a background task failed. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephbirkner merged 4 commits into from
Aug 10, 2023
Merged

Exit with error from test-wheel.bash if a background task failed. #8

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57e782f
Exit with error from test-wheel.bash if a background task failed.
l-laura Aug 10, 2023
1831849
Improved log messages in test_wheel.bash.
l-laura Aug 10, 2023
9054023
Remove exit 0 form test-wheel.bash and enable set -e
josephbirkner Aug 10, 2023
223607f
Merge pull request #9 from Klebert-Engineering/test-wheel-exit-0-set-e
josephbirkner Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions test-wheel.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/usr/bin/env bash

set -e

my_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
. "$my_dir/python.bash"

Expand All @@ -13,13 +15,30 @@ pip install pytest
cleanup=true

trap '
if [[ -n $(jobs -p) ]]; then
echo "→ Killing $(jobs -p)"
kill $(jobs -p)
fi
failed_pids=()
for pid in $(jobs -p); do
if kill -0 $pid >/dev/null 2>&1; then
# Background process is still running - good.
kill $pid
else
exit_status=$?
if [[ $exit_status -eq 0 ]]; then
echo "Background task $pid already exited with zero status."
else
echo "Background task $pid exited with nonzero status ($exit_status)."
failed_pids+=("$pid")
fi
fi
done

if [[ "$cleanup" == "true" ]]; then
echo "→ Removing $venv"; rm -rf "$venv"
fi

if [[ ${#failed_pids[@]} -gt 0 ]]; then
echo "The following background processes exited with nonzero status: ${failed_pids[@]}"
exit 1
fi
' EXIT

while [[ $# -gt 0 ]]; do
Expand All @@ -31,14 +50,15 @@ while [[ $# -gt 0 ]]; do
shift
;;
-b|--background)
echo "→ Launching Background Task $2 ..."
echo "→ Launching background task: $2"
$2 &
echo "... started with PID: $!"
sleep 5
shift
shift
;;
-f|--foreground)
echo "→ Starting $2 ..."
echo "→ Starting foreground task: $2"
$2
shift
shift
Expand All @@ -51,5 +71,3 @@ while [[ $# -gt 0 ]]; do
;;
esac
done

exit 0