Skip to content

Backport long comment fix#131

Merged
zendern merged 1 commit intomainfrom
long-preview-comment-fix
Mar 5, 2026
Merged

Backport long comment fix#131
zendern merged 1 commit intomainfrom
long-preview-comment-fix

Conversation

@zendern
Copy link
Contributor

@zendern zendern commented Mar 5, 2026

Link to Issue or Message thread

LabAutomationAndScreening/copier-pulumi-project#30

Why is this change necessary?

We had a preview that was very very long breaking the limit that is allowed by Github comments.

How does this change address the issue?

Backports the fix that we added to the copier-pulumi-project

What side effects does this change have?

Fixes if previews get too long

Summary by CodeRabbit

Release Notes

Improvements

  • Pulumi deployment preview comments in pull requests now feature improved output formatting and handling
  • Large deployment previews gracefully truncate when exceeding size limits while providing links to view complete logs
  • Enhanced preview comment generation and delivery mechanism for increased reliability

@zendern zendern requested a review from ejfine March 5, 2026 15:38
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The Pulumi ephemeral deploy action workflow was refactored to replace an external action for capturing Pulumi CLI output with an inline shell script. The new approach collects output into a variable, formats it as Markdown, writes it to a temporary file with size constraints, and posts the file to pull request comments instead of direct inline messages.

Changes

Cohort / File(s) Summary
Pulumi Ephemeral Deploy Action
template/template/.github/actions/pulumi_ephemeral_deploy/action.yml.jinja-base
Modified CLI output capture mechanism: replaced external action with inline shell script that constructs Markdown-formatted preview, implements 65,535 byte truncation threshold with fallback message and link, and writes to temporary file for PR comment posting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • ejfine
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Backport long comment fix' is directly related to the main change, which involves backporting a fix for handling long Pulumi preview comments that exceed GitHub's limits.
Description check ✅ Passed The pull request description covers the required sections from the template with appropriate content: issue link, clear motivation, explanation of the fix, and side effects. Only the testing section is missing but is non-critical.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zendern zendern merged commit b5ef020 into main Mar 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants