Skip to content

Fix for output not showing when its too long#133

Merged
zendern merged 2 commits intomainfrom
fix-for-output-not-showing
Mar 9, 2026
Merged

Fix for output not showing when its too long#133
zendern merged 2 commits intomainfrom
fix-for-output-not-showing

Conversation

@zendern
Copy link
Contributor

@zendern zendern commented Mar 9, 2026

Why is this change necessary?

When we have a PR comment that exceeds the size of the allowed limit we fixed it by sending a smaller message and link but when you go review the output the actual command output was not available for review.

##How does this change address the issue?

Outputs the command output when the value is too long.

What side effects does this change have?

Shows the preview output now

How is this change tested?

CI

Summary by CodeRabbit

  • Chores
    • Enhanced output visibility in the deployment workflow for improved debugging and monitoring of deployment operations.

@zendern zendern requested a review from ejfine March 9, 2026 01:58
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Warning

Rate limit exceeded

@zendern has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e14eecc7-8a57-46a6-b0dc-99dde021471f

📥 Commits

Reviewing files that changed from the base of the PR and between 5208314 and 404822d.

📒 Files selected for processing (1)
  • template/template/.github/actions/{% if template_uses_pulumi %}pulumi_ephemeral_deploy{% endif %}/action.yml.jinja-base
📝 Walkthrough

Walkthrough

The pull request adds an echo statement to the Pulumi ephemeral deploy action workflow to display the captured output from the deploy command execution, improving visibility of deployment process output without modifying control flow or error handling.

Changes

Cohort / File(s) Summary
Pulumi Ephemeral Deploy Action
template/template/.github/actions/pulumi_ephemeral_deploy/action.yml.jinja-base
Adds echo statement to print captured output from the deploy CLI execution, improving stdout visibility of the deployment process.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Backport long comment fix #131: Modifies the same Pulumi ephemeral deploy action file to change how the Pulumi CLI output is captured and displayed in PR previews.

Suggested reviewers

  • ejfine
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing output visibility when it exceeds size limits, which aligns with the changeset's purpose of echoing deploy command output.
Description check ✅ Passed The description covers all required template sections with sufficient detail: issue context, solution explanation, side effects, and testing approach. All major sections are present and adequately filled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@template/template/.github/actions/`{% if template_uses_pulumi
%}pulumi_ephemeral_deploy{% endif %}/action.yml.jinja-base:
- Around line 84-85: The script prints the Pulumi preview using an unquoted
variable which collapses newlines and risks glob expansion; update the echo
invocation in the template (the line containing echo $output) to quote the
variable so multi-line output and special characters are preserved (i.e.,
replace the unquoted echo $output with a quoted echo of the same variable).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e6addfee-0ac2-4f97-936c-aef6a3485718

📥 Commits

Reviewing files that changed from the base of the PR and between 09fda0b and 5208314.

📒 Files selected for processing (1)
  • template/template/.github/actions/{% if template_uses_pulumi %}pulumi_ephemeral_deploy{% endif %}/action.yml.jinja-base

@zendern zendern merged commit 7a235db into main Mar 9, 2026
7 checks passed
zendern added a commit to LabAutomationAndScreening/copier-aws-central-infrastructure that referenced this pull request Mar 9, 2026
## Why is this change necessary?
General updates but does help test out
LabAutomationAndScreening/copier-base-template#133
since we will pull it downstream and verify it works.


## How does this change address the issue?
Sync latest and greatest from base template


## What side effects does this change have?
N/A


## How is this change tested?
CI



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Integrated Beads for issue tracking and task management within
development workflows
* Added comprehensive Claude Code command guides for TDD, refactoring,
code review, and decision documentation
* Added architecture decision records (ADRs) support for design tracking

* **Documentation**
* Added detailed coding standards, testing practices, and tooling
guidance (AGENTS.md)
  * Added code coverage configuration for test quality metrics

* **Chores**
* Updated development tools, VS Code extensions, and dependencies to
latest versions
  * Enhanced pre-commit hooks with Claude Code settings management

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants