Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis update revises several configuration files, primarily upgrading tool versions, adjusting pre-commit hook exclusions, and modifying or removing biome configuration files. Version strings for Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Pre-commit Hooks
participant Linter/Formatter
Developer->>Pre-commit Hooks: Run hooks on commit
Pre-commit Hooks->>Linter/Formatter: Apply only to included files (per new exclusions)
Linter/Formatter-->>Pre-commit Hooks: Skip excluded/minified/generated files
Pre-commit Hooks-->>Developer: Report results
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the lint configuration by migrating from Biome JSON to JSONC files, updating tool versions, and improving file exclusion patterns. The changes focus on ignoring unnecessary ruff rules and excluding various generated/bundled files from formatting checks.
- Migrates Biome configuration from
.jsonto.jsoncformat with enhanced file inclusion/exclusion rules - Updates tool versions for ruff, typos, biome, pyright, and pnpm
- Adds TC006 rule to ruff ignore list to prevent unnecessary quote additions around classes
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| biome.jsonc | New main Biome configuration with formatter/linter disabled and file exclusion patterns |
| biome.json | Removed old Biome configuration file |
| template//biome. | Updated template references to use .jsonc instead of .json |
| ruff.toml | Added TC006 rule to ignore list and updated pyright version |
| pyproject.toml | Updated pyright version dependency |
| extensions/context.py | Updated version numbers for pnpm and pyright |
| .pre-commit-config.yaml | Updated tool versions and expanded file exclusion patterns |
| .devcontainer/devcontainer.json | Updated devcontainer context hash |
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "formatter": { | |||
| "enabled": false, | |||
There was a problem hiding this comment.
[nitpick] Trailing comma after the last property in the formatter object is unnecessary and inconsistent with the linter object below.
| "enabled": false, | |
| "enabled": false |
Why is this change necessary?
Some new rules and things to ignore
How does this change address the issue?
Ignoring ruff rule that adds extra quotes
Ignoring formatting of snapshot files and some bundled asset files
What side effects does this change have?
None
How is this change tested?
downstream repos
Summary by CodeRabbit
Chores
Refactor
Style