Skip to content

Update Lint config#70

Merged
ejfine merged 13 commits intomainfrom
lint-config
Jul 14, 2025
Merged

Update Lint config#70
ejfine merged 13 commits intomainfrom
lint-config

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Jul 14, 2025

Why is this change necessary?

Some new rules and things to ignore

How does this change address the issue?

Ignoring ruff rule that adds extra quotes

Ignoring formatting of snapshot files and some bundled asset files

What side effects does this change have?

None

How is this change tested?

downstream repos

Summary by CodeRabbit

  • Chores

    • Updated pre-commit hooks to newer versions and refined exclusion patterns to skip generated, minified, and configuration files.
    • Updated tool versions for pnpm and pyright.
    • Updated dependency requirement for pyright.
    • Refreshed devcontainer context hash.
  • Refactor

    • Removed and replaced various configuration files related to code formatting and linting.
    • Added new configuration files with updated inclusion/exclusion rules and disabled certain features.
    • Adjusted linting rules to ignore specific cases for improved IDE compatibility.
  • Style

    • Added empty configuration template files for future use.

@ejfine ejfine requested a review from Copilot July 14, 2025 11:06
@ejfine ejfine self-assigned this Jul 14, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update revises several configuration files, primarily upgrading tool versions, adjusting pre-commit hook exclusions, and modifying or removing biome configuration files. Version strings for pnpm and pyright are incremented, a new lint ignore rule is added, and biome configuration files are consolidated and replaced with new JSONC variants, some of which are now empty.

Changes

Files / Groups Change Summary
.devcontainer/devcontainer.json Updated context hash comment.
.pre-commit-config.yaml Upgraded hook versions; expanded exclusion patterns for multiple hooks.
biome.json, template/biome.json, template/template/biome.json Deleted old biome configuration files.
biome.jsonc, template/biome.jsonc, template/template/biome.jsonc Added new biome JSONC files; main and template versions, some empty or referencing others.
extensions/context.py Updated pnpm_version and pyright_version strings in ContextUpdater.hook.
pyproject.toml Bumped pyright[nodejs] dependency minimum version.
ruff.toml Added "TC006" to lint ignore list with explanatory comment.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Pre-commit Hooks
    participant Linter/Formatter

    Developer->>Pre-commit Hooks: Run hooks on commit
    Pre-commit Hooks->>Linter/Formatter: Apply only to included files (per new exclusions)
    Linter/Formatter-->>Pre-commit Hooks: Skip excluded/minified/generated files
    Pre-commit Hooks-->>Developer: Report results
Loading

Possibly related PRs

Poem

A hop, a skip, a version bump or two,
The biome files are fresh and new!
Hooks now skip the minified crowd,
And ruff ignores what’s not allowed.
With every tweak, the garden’s neat—
This rabbit’s work is quite the feat! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2dca74 and 0060cb6.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • .devcontainer/devcontainer.json (1 hunks)
  • .pre-commit-config.yaml (4 hunks)
  • biome.json (0 hunks)
  • biome.jsonc (1 hunks)
  • extensions/context.py (1 hunks)
  • pyproject.toml (1 hunks)
  • ruff.toml (1 hunks)
  • template/biome.json (0 hunks)
  • template/biome.jsonc (1 hunks)
  • template/template/biome.json (0 hunks)
  • template/template/biome.jsonc (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the lint configuration by migrating from Biome JSON to JSONC files, updating tool versions, and improving file exclusion patterns. The changes focus on ignoring unnecessary ruff rules and excluding various generated/bundled files from formatting checks.

  • Migrates Biome configuration from .json to .jsonc format with enhanced file inclusion/exclusion rules
  • Updates tool versions for ruff, typos, biome, pyright, and pnpm
  • Adds TC006 rule to ruff ignore list to prevent unnecessary quote additions around classes

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
biome.jsonc New main Biome configuration with formatter/linter disabled and file exclusion patterns
biome.json Removed old Biome configuration file
template//biome. Updated template references to use .jsonc instead of .json
ruff.toml Added TC006 rule to ignore list and updated pyright version
pyproject.toml Updated pyright version dependency
extensions/context.py Updated version numbers for pnpm and pyright
.pre-commit-config.yaml Updated tool versions and expanded file exclusion patterns
.devcontainer/devcontainer.json Updated devcontainer context hash

@@ -0,0 +1,16 @@
{
"formatter": {
"enabled": false,
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Trailing comma after the last property in the formatter object is unnecessary and inconsistent with the linter object below.

Suggested change
"enabled": false,
"enabled": false

Copilot uses AI. Check for mistakes.
@ejfine ejfine merged commit 856bdf9 into main Jul 14, 2025
6 of 7 checks passed
@ejfine ejfine deleted the lint-config branch July 14, 2025 11:08
@coderabbitai coderabbitai bot mentioned this pull request Aug 11, 2025
This was referenced Sep 15, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 1, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 27, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants